-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove problematic discovery test #336
Conversation
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Can we just disable the test on the platforms where it fails, instead of removing it? |
Codecov Report
@@ Coverage Diff @@
## main #336 +/- ##
=======================================
Coverage ? 88.11%
=======================================
Files ? 52
Lines ? 4848
Branches ? 0
=======================================
Hits ? 4272
Misses ? 576
Partials ? 0 Continue to review full report at Codecov.
|
We can, as it turns out, we don't have a macro to disable a test only on Linux, I suppose it's never been needed before? |
Signed-off-by: Michael Carroll <michael@openrobotics.org>
New warnings on windows are to be addressed elsewhere. |
Would you be able to backport this to Citadel and merge forward to Fortress? Thanks! |
Done: #339 |
This test has recently appeared to fail, we have some on-going diagnosis in #335. In the meantime, I think it makes sense to disable to get CI back into a reasonable state.