Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement ExtraTestMacros for all platforms #74

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Fixes gazebosim/gz-transport#336

Summary

When working on gazebosim/gz-transport#336, I noticed that we don't have the full set of macros for enabling/disabling tests on a per-platform basis. These may not all get used, but it at least completes the set.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll requested a review from azeey as a code owner July 26, 2022 16:41
@mjcarroll mjcarroll changed the title Round out ExtraTestMacros Implement ExtraTestMacros for all platforms Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #74 (d60b5d7) into main (41189fd) will not change coverage.
The diff coverage is n/a.

❗ Current head d60b5d7 differs from pull request most recent head 9f5b654. Consider uploading reports for the commit 9f5b654 to get more accurate results

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   41.00%   41.00%           
=======================================
  Files          17       17           
  Lines        2334     2334           
=======================================
  Hits          957      957           
  Misses       1377     1377           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41189fd...9f5b654. Read the comment docs.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 26, 2022
@mjcarroll mjcarroll self-assigned this Jul 26, 2022
@chapulina chapulina merged commit 79345c6 into main Jul 26, 2022
@chapulina chapulina deleted the mjcarroll/finish_test_macros branch July 26, 2022 19:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants