Added to light if the light is on or off

[ahcorde]

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Related with:

• Issues: Related with this issue Toggling light visualization in ign-gazebo5 gz-sim#638
• PR Allow to turn on/off lights gz-sim#1343

This will allow to define if a light is on or off.

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[nkoenig]

I'm having second thoughts on this. An intensity value of zero is effectively off. Is it possible to use the existing intensity field instead of creating a new field?

[ahcorde]

I'm having second thoughts on this. An intensity value of zero is effectively off. Is it possible to use the existing intensity field instead of creating a new field?

This value allows you to turn on and off for a specific value of intensity, otherwise you need to set to zero the intensity and then restore or add a new value to the intensity.

I don't know if this is a good reason to add a new value.

[codecov-commenter]

Codecov Report

Merging #851 (baa8cf5) into sdf11 (61412e6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head baa8cf5 differs from pull request most recent head 706494c. Consider uploading reports for the commit 706494c to get more accurate results

@@           Coverage Diff           @@
##            sdf11     #851   +/-   ##
=======================================
  Coverage   88.90%   88.91%           
=======================================
  Files          73       73           
  Lines       11079    11086    +7     
=======================================
+ Hits         9850     9857    +7     
  Misses       1229     1229           

Impacted Files	Coverage Δ
src/Light.cc	91.76% <100.00%> (+0.35%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61412e6...706494c. Read the comment docs.

[nkoenig]

I'm having second thoughts on this. An intensity value of zero is effectively off. Is it possible to use the existing intensity field instead of creating a new field?

This value allows you to turn on and off for a specific value of intensity, otherwise you need to set to zero the intensity and then restore or add a new value to the intensity.

I don't know if this is a good reason to add a new value.

That's a good point. I'm okay with this.

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1