Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added light visualize #877

Merged
merged 2 commits into from
Mar 12, 2022
Merged

Added light visualize #877

merged 2 commits into from
Mar 12, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Mar 11, 2022

🎉 New feature

Summary

Related with this issue gazebosim/gz-sim#638 (comment)

This will allow to enable/disable the light visual

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina March 11, 2022 18:15
@ahcorde ahcorde requested a review from azeey as a code owner March 11, 2022 18:15
@ahcorde ahcorde self-assigned this Mar 11, 2022
@ahcorde ahcorde requested a review from scpeters as a code owner March 11, 2022 18:15
@ahcorde ahcorde added 🏢 edifice Ignition Edifice OOBE 📦✨ Out-of-box experience labels Mar 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #877 (55176f1) into sdf11 (2e396c7) will decrease coverage by 0.00%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            sdf11     #877      +/-   ##
==========================================
- Coverage   88.91%   88.91%   -0.01%     
==========================================
  Files          73       73              
  Lines       11086    11094       +8     
==========================================
+ Hits         9857     9864       +7     
- Misses       1229     1230       +1     
Impacted Files Coverage Δ
src/Model.cc 89.36% <80.00%> (-0.16%) ⬇️
src/Light.cc 92.09% <100.00%> (+0.32%) ⬆️
src/parser.cc 86.72% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ba371...55176f1. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@ahcorde
Copy link
Collaborator Author

ahcorde commented Mar 11, 2022

@osrf-jenkins retest this please

@chapulina chapulina enabled auto-merge March 12, 2022 01:05
@chapulina chapulina disabled auto-merge March 12, 2022 01:05
@chapulina chapulina enabled auto-merge (squash) March 12, 2022 01:06
@chapulina chapulina disabled auto-merge March 12, 2022 01:06
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor

I addressed my comments in 55176f1 so we can merge this and make a release.

@chapulina chapulina enabled auto-merge (squash) March 12, 2022 02:09
@chapulina chapulina mentioned this pull request Mar 12, 2022
7 tasks
@chapulina chapulina merged commit a5b7a19 into sdf11 Mar 12, 2022
@chapulina chapulina deleted the ahcorde/11/lightsVisualize branch March 12, 2022 02:58
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏢 edifice Ignition Edifice OOBE 📦✨ Out-of-box experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants