Fix azure pre-signed urls #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure URL signing was broken. The journal prefix was being duplicated in the URL, which resulted in unusable URLs. Clients would fail with a 403 response when attempting to fetch the fragment. This removes the extra prefix to hopefully allow signing to work.
|
I've tested this locally and confirmed that I was able to read a fragment using the pre-signed URL. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure URL signing was broken. The journal prefix was being duplicated in the URL, which resulted in unusable URLs. Clients would fail with a 403 response when attempting to fetch the fragment. This removes the extra prefix to hopefully allow signing to work.
This change is