Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(popover): fix the undefined classname #307

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

firede
Copy link
Contributor

@firede firede commented Jul 2, 2020

Checklist

  • Fix linting errors
  • Label has been added

Change information

Changes

  • Popover: add default portalClassName
  • Popover.Item: add default className

Snapshots

image
image

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #307 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         186      186           
  Lines        2373     2373           
  Branches      568      568           
=======================================
  Hits         2372     2372           
  Misses          1        1           
Impacted Files Coverage Δ
components/popover/popover.tsx 100.00% <ø> (ø)
components/popover/popover-item.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f8a6a3...e6792ff. Read the comment docs.

@unix unix added the type: bug Something isn't working label Jul 2, 2020
Copy link
Member

@unix unix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great work! Thank you for your contribution.

@unix unix merged commit c51e158 into geist-org:master Jul 2, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants