Skip to content

fix(popover): fix the undefined classname #307

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 2, 2020
Merged

fix(popover): fix the undefined classname #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/popover/popover-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ interface Props {
const defaultProps = {
line: false,
title: false,
className: '',
}

type NativeAttrs = Omit<React.HTMLAttributes<any>, keyof Props>
Expand Down Expand Up @@ -71,7 +72,7 @@ const PopoverItem: React.FC<React.PropsWithChildren<PopoverItemProps>> = ({
}
`}</style>
</div>
{title && <PopoverItem line title={false} />}
{title && <PopoverItem line title={false} className="" />}
</>
)
}
Expand Down
1 change: 1 addition & 0 deletions components/popover/popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ interface Props {
const defaultProps = {
trigger: 'click' as TriggerTypes,
placement: 'bottom' as Placement,
portalClassName: '',
}

type ExcludeTooltipProps = {
Expand Down