-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Cloud instance name should allow leading numerics #420
Comments
this has an unofficial but legit-looking regex for org slug. the "no consecutive hyphens" and "can't start or end with a hyphen" requirements may not be relevant for our regex because we shouldn't ever see a Github user with that name...but it does mean that we can safely treat I think cloud & local instance names should have identical requirements unless there's a very good reason to make them separate. if I have a local instance and want to migrate it to be hosted in the cloud, it would be annoying friction to be required to make up a new instance name as well |
With the updates from the discussion, this is not valid any more because:
The best we can do now is to allow single dashes |
Changes ======= * Update for rules of instance names (#423) (by @fantix in 5bc5699 for #420) * Synchronize error types (#429) (by @fantix in 03e4012) * Allow enums in array codec (#431) (by @fantix in 2de7e3f for #408) * Prohibit concurrent operations on the same transaction object (#430) (by @fantix in f1fa612 for #130) * Fix state of transaction start (#424) (by @fantix in 297de72) * codegen: Handle non-identifier characters in enum values (#432) (by @fantix in e1ec16d for #428) Docs ==== * docs: add Code Generation to table of contents (#421) (by @AndreasPB in ffe74a1 for #421)
1st1/test
orfantix/1st1test
should be accepted as valid instance names.^(\w(?:\w|-(?=\w))*)(?:/(\w(?:\w|-(?=\w))*))?$
/
(inclusive) is present, so that the translated cloud domain labelinst--org
is no longer than 63 letters.The text was updated successfully, but these errors were encountered: