Update for rules of instance names #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Instance names allow leading digits * Cloud instance name max length: 62 * Dashes are allowed, except for consecutive ones like --
elprans
reviewed
Mar 14, 2023
elprans
reviewed
Mar 14, 2023
| @@ -861,6 +865,12 @@ def _parse_cloud_instance_name_into_config( | |||
| org_slug: str, | |||
| instance_name: str, | |||
| ): | |||
| label = f"{instance_name}--{org_slug}" | |||
| if len(label) > 63: | |||
| raise ValueError( | |||
There was a problem hiding this comment.
Should probably be errors.InterfaceError or a subclass.
There was a problem hiding this comment.
I'll create a new PR for this - too many of them to fix in a CRF.
elprans
reviewed
Mar 14, 2023
elprans
approved these changes
Mar 14, 2023
vpetrovykh
reviewed
Mar 14, 2023
fantix
added a commit
that referenced
this pull request
May 26, 2023
* Instance names allow leading digits * Cloud instance name max length: 62 * Dashes are allowed, except for consecutive ones like -- * Ban underscores for the cloud
fantix
added a commit
that referenced
this pull request
May 26, 2023
Changes ======= * Update for rules of instance names (#423) (by @fantix in 5bc5699 for #420) * Synchronize error types (#429) (by @fantix in 03e4012) * Allow enums in array codec (#431) (by @fantix in 2de7e3f for #408) * Prohibit concurrent operations on the same transaction object (#430) (by @fantix in f1fa612 for #130) * Fix state of transaction start (#424) (by @fantix in 297de72) * codegen: Handle non-identifier characters in enum values (#432) (by @fantix in e1ec16d for #428) Docs ==== * docs: add Code Generation to table of contents (#421) (by @AndreasPB in ffe74a1 for #421)
Merged
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #420
Depends on geldata/shared-client-testcases#27