Merge pull request #1174 from geoadmin/pb-1278-icon-offset

PB-1278: Fix Icon with offset (pin) changes positon
geoadmin · Jan 13, 2025 · 162eb9c · 162eb9c
2 parents 74f0174 + a7cd57f
commit 162eb9c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/api/print.api.js b/src/api/print.api.js
@@ -134,10 +134,7 @@ class GeoAdminCustomizer extends BaseCustomizer {
                   )
                 : 0
             // don't ask why it works, but that's the best I could do.
-
-            symbolizer.graphicYOffset = symbolizer.graphicYOffset
-                ? (symbolizer.graphicYOffset = adjustWidth(-size[1], this.printResolution))
-                : 0
+            symbolizer.gaphicYOffset = Math.round(1000 * symbolizer.gaphicYOffset ?? 0) / 1000
         }
         if (size) {
             symbolizer.graphicWidth = adjustWidth(size[0] * scale, this.printResolution)

diff --git a/src/utils/styleUtils.js b/src/utils/styleUtils.js
@@ -161,9 +161,11 @@ export const highlightPointStyle = new Style({
 // Change a width according to the change of DPI (from the old geoadmin)
 // Originally introduced here https://github.com/geoadmin/mf-geoadmin3/pull/3280
 export function adjustWidth(width, dpi) {
-    if (!width || isNaN(width) || width <= 0.0 || !dpi || isNaN(dpi) || dpi <= 0) {
+    if (!width || isNaN(width) || !dpi || isNaN(dpi) || dpi <= 0) {
         return 0
     }
-
+    if (width <= 0) {
+        return -adjustWidth(-width, dpi)
+    }
     return Math.max((width * PRINT_DPI_COMPENSATION) / dpi, MIN_PRINT_SCALE_SIZE)
 }