Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

PB-1278: Fix Icon with offset (pin) changes positon #1174

Merged
merged 4 commits into from
Jan 13, 2025
Merged

PB-1278: Fix Icon with offset (pin) changes positon #1174

merged 4 commits into from
Jan 13, 2025

Conversation

ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Dec 17, 2024 •
edited
Loading

Need to be reviewd by @ltkum as this revert his change in #1015

Test link

Sample on 1:500 and 1:5000. Looks good
image

Test link

@cypress Cypress
Copy link

cypress bot commented Dec 17, 2024 •
edited
Loading

web-mapviewer    Run #4256

Run Properties:  status check passed Passed #4256  •  git commit 162eb9c8c9: Merge pull request #1174 from geoadmin/pb-1278-icon-offset
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #4256
Run duration 01m 48s
Commit git commit 162eb9c8c9: Merge pull request #1174 from geoadmin/pb-1278-icon-offset
Committer Ismail Sunni
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

@ismailsunni ismailsunni marked this pull request as ready for review December 17, 2024 08:14
@ismailsunni ismailsunni requested review from ltkum and pakb December 17, 2024 08:14
pakb
pakb reviewed Dec 17, 2024
View reviewed changes
src/api/print.api.js Outdated Show resolved Hide resolved
src/utils/styleUtils.js Show resolved Hide resolved
ismailsunni
ismailsunni commented Dec 21, 2024
View reviewed changes
src/api/print.api.js Outdated Show resolved Hide resolved
@ismailsunni ismailsunni requested review from pakb and removed request for pakb January 6, 2025 23:19
ltkum
ltkum reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@ltkum ltkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a last small change and we should be good to go :)

src/api/print.api.js Outdated Show resolved Hide resolved
@ismailsunni ismailsunni requested a review from ltkum January 7, 2025 10:34
ltkum
ltkum approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@ltkum ltkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go :)

Thanks

@ismailsunni ismailsunni merged commit 162eb9c into develop Jan 13, 2025
6 checks passed
@ismailsunni ismailsunni deleted the pb-1278-icon-offset branch January 13, 2025 06:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pakb pakb pakb left review comments

@ltkum ltkum ltkum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ismailsunni @pakb @ltkum