Fix tagged CO simulation in dev branch #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was introduced when 14.5.0 was merged into the dev/no-diff-to-benchmark branch. It reverted a change that came in with the CO2 updates. This commit fixes failing integration tests for tagged CO. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
added
category: Bug
yantosca
requested changes
Dec 3, 2024
yantosca
approved these changes
Dec 3, 2024
yantosca
added
category: Bug Fix
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR fixes a bug introduced to the dev/no-diff-to-benchmark branch when 14.5.0 was merged in. That merge reverted an
update to change the start date and restart file for tagged CO simulations. With this updates the tagged CO integration tests will no longer fail.
Note that there is no need for a changelog update because the issue is only in the dev/no-diff-to-benchmark branch and is not in any official releases.
Expected changes
Tagged CO simulations will use the carbon restart file and start on Jan 1 by default. This returns functionality introduced in the CO2 updates in the dev/no-diff-to-benchmark branch.
Reference(s)
None
Related Github Issue
None needed since bug is not in any releases.