Fixed deleting entities from lists with special characters #6561
Conversation
grzesiek2010
force-pushed
the
COLLECT-6559
branch
from
d8a5328 to
d0fb959
Compare
Fixed. |
| repository.save("wines.x", leoville) | ||
| repository.save("wines-x", leoville) | ||
|
|
||
| repository.delete("1") |
There was a problem hiding this comment.
This makes me realize that delete should probably take a list as an arg as well, but that's for another time!
| @@ -198,7 +198,7 @@ class DatabaseEntitiesRepository(context: Context, dbPath: String) : EntitiesRep | |||
| databaseConnection.withConnection { | |||
| getLists().forEach { | |||
| writableDatabase.delete( | |||
| it, | |||
| "`$it`", | |||
There was a problem hiding this comment.
Is there a reason to use backticks here instead of quotes like in the rest of the file?
There was a problem hiding this comment.
No, it looks like we can use both.
There was a problem hiding this comment.
Ok let's make it consistent. Maybe we should introduce a quote method?
There was a problem hiding this comment.
Oh weird I said: No, it looks like we can use both. and at the same time made it consistent but it looks like I didn't push the changes...
|
Tested with Success! Verified on a device with Android 10 and 12 (by Szymon) Verified cases:
|
|
Tested with Success Verified on device with Android 15 |
Fixed deleting entities from lists with special characters
Closes #6559
Why is this the best possible solution? Were any other approaches considered?
We need to quote the list name to make it possible to use special characters in table names in SQL. It's not the first issue like that so this approach is the same as it was before in the case of similar problems.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We’ve encountered issues with handling special characters in entities in other areas before, so this isn’t a new problem. Please test it as described in the issue (deleting entities), but keep in mind that this might not be the last case we’ll need to address.
Do we need any specific form for testing your changes? If so, please attach one.
Any form with entities where lists contain special characters like
.or-.Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest