-
-
Notifications
You must be signed in to change notification settings - Fork 133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs test.
Added tests. Feels kinda messy compared to the raven-js parallels with the nice sinon setup :/ |
593b1a1
to
73d4f2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍗
Sorry for the dumb question, but what is the use case for this? |
@MarkHerhold – This is analogous to rate-limiting, except the rate-limiting occurs on the client, not the server. This has the upside of sending less traffic to sentry.io ($) / your own Sentry server at the expense of losing data. Sampling is often necessary for very high traffic applications. |
Ah, so this would be for applications that are utilizing Sentry more like a logging service rather than an error tracker? |
It's more like – if you have 1 million active users, and they all hit the same error, do you really need 1 million error reports to be sent? Probably not. So, if you have an app with a really huge active user count, you can probably safely suppress a fraction of error reports using |
Got it, thanks! |
Basically the same thing as getsentry/sentry-javascript#885
/cc @benvinegar @dcramer