Add sampleRate config option #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not immediately sure why this is failing, will look more tomorrow. |
benvinegar
suggested changes
Mar 13, 2017
|
🍀🥊 |
|
@benvinegar figured out/fixed why it was failing & added tests. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if we're worried about testing this; we didn't in getsentry/raven-python#978.
I'm also not sure if we want to wait until after dataCallback, shouldSendCallback, etc before applying the sample factor, or apply it before we get to them; I followed the python implementation's lead here and applied it after.
I also simplified the docs wording a bit relative to raven-python. We might want to clarify somehow the difference between setting sample rate to 0 and just disabling raven?
/cc @dcramer @benvinegar