feat(event-schema): Add getters for most contexts in Discover #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olksdr
approved these changes
Oct 13, 2023
iker-barriocanal
approved these changes
Oct 16, 2023
jjbayer
approved these changes
Oct 16, 2023
This was referenced Oct 23, 2023
jan-auer
force-pushed
the
feat/getter-contexts
branch
from
3215bda
to
3f204a1
Compare
iambriccardo
approved these changes
Oct 23, 2023
armenzg
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 23, 2023
Adds more fields to the mapping for on-demand metric rules. Now that getsentry/relay#2607 got merged we need to update the list of supported fields.
This was referenced Oct 23, 2023
armenzg
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 23, 2023
Adds more fields to the mapping for on-demand metric rules. Now that getsentry/relay#2607 got merged we need to update the list of supported fields. Fixes #56929
jan-auer
added a commit
that referenced
this pull request
Nov 16, 2023
Getter access for device context fields added in #2607 missed `device.model`. This PR adds this field so it can be used for on-demand metric extraction.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add field implementations in the
GetteronEventfor most contexts declared by Discover. This is needed for ondemand metric extraction in widgets, so that all context fields can be used in widget queries.For the full list of Discover fields, see:
https://github.com/getsentry/sentry/blob/master/src/sentry/snuba/events.py
After this has merged, the metrics extraction allow list in Sentry can be updated. It is located here:
https://github.com/getsentry/sentry/blob/8c61340c93045bc1c9e4d1fa1a77b062c8dfb44e/src/sentry/snuba/metrics/extraction.py#L51