Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(inbound-filters) Add support for inbound filtering of legacy Edge browsers #2650

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

RaduW
Copy link
Contributor

@RaduW RaduW commented Oct 24, 2023

This PR adds support for filtering legacy edge browser to the LegacyBrowsers inbound filter.

When this option is enabled any edge browser with major version < 79 will be filtered.
Effectively this means that browsers version 12 through 18 will be filtered ( from 18 it jumped to 79).

Resolves: getsentry/sentry#29707

@RaduW RaduW requested a review from a team October 24, 2023 09:54
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
@RaduW RaduW merged commit 7844e2b into master Oct 24, 2023
20 checks passed
@RaduW RaduW deleted the feat/inbound-filter/legacy-edge branch October 24, 2023 11:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add legacy Edge versions 12-18 to Inbound Data Filters
3 participants