Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add legacy Edge versions 12-18 to Inbound Data Filters #29707

Closed
mKlus opened this issue Nov 1, 2021 · 11 comments · Fixed by #58600, #58606 or getsentry/relay#2650
Closed

Add legacy Edge versions 12-18 to Inbound Data Filters #29707

mKlus opened this issue Nov 1, 2021 · 11 comments · Fixed by #58600, #58606 or getsentry/relay#2650

Comments

@mKlus
Copy link

mKlus commented Nov 1, 2021

Problem Statement

Edge versions 12-18 is obsoleted and has a limited javascript API functionality.
Many web apps/pages dropped support for Edge 12-18 and it would make sense to be able to setup a rule to ignore any errors coming from Edge 12-18 the same way we can ignore errors coming from Internet Explorer.

image

Solution Brainstorm

No response

@mKlus
Copy link
Author

mKlus commented Nov 2, 2021

Thinking about this bit more, I wonder if that should be extended to all browsers so we have an ability to filter out errors from unsupported browsers, including older versions of Chrome, Firefox etc.

@getsentry-release
Copy link

Routing to @getsentry/owners-ingest for triage. ⏲️

@untitaker
Copy link
Member

Thanks, I have added this to our backlog. It may be that this feature generally needs to become more flexible to adapt to browsers becoming outdated over time.

@mKlus
Copy link
Author

mKlus commented Nov 2, 2021

Hi @untitaker, thanks for adding this to the backlog. Do you have an approximate time when this could be released?

@untitaker
Copy link
Member

Sorry, no. I can only say that your feedback has been recorded, we can't commit to working on it yet.

@mKlus
Copy link
Author

mKlus commented Nov 3, 2021

Thanks @untitaker. Is there any work around that you would recommend?

@untitaker
Copy link
Member

There's not a whole lot you can do on the serverside at the moment, but you could disable the SDK on the clientside if the useragent is bad/old?

@jitendravyas
Copy link

Please do this for firefox too https://twitter.com/jitendravyas/status/1549701901088079873

@mscuthbert
Copy link

This would be very helpful for one of my projects which does a lot with modern WebAudio and our issues reports get clogged with people ignoring the BrowserUpdate notifications saying that it won't work for them and continuing into the site.

(If you're looking for a syntax to use, the BrowserUpdate configuration is well known and many people will be able to adopt it directly. Though you'll probably want a much more permissive default than they use).

(Adding OS filtering as well would also let me filter out a notorious web crawler that crashes on all modern JS and reports Safari 10.0 on Linux, which doesn't exist)

@johannesnagl
Copy link

same here: i think this would be super helpful. we would definitely need some additional rules here:

Screenshot 2023-09-13 at 14 13 26

as mentioned in #54934, specifying a browserslist would make a lot of sense.

@hubertdeng123
Copy link
Member

Removing Waiting for: Product Owner since it looks like it is on the backlog of Telemetry Experience

RaduW added a commit to getsentry/relay that referenced this issue Oct 24, 2023
…e browsers (#2650)

This PR adds support for filtering legacy edge browser to the
LegacyBrowsers inbound filter.

When this option is enabled any edge browser with major version < 79
will be filtered.
Effectively this means that browsers version 12 through 18 will be
filtered ( from 18 it jumped to 79).

Resolves: getsentry/sentry#29707

---------

Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.