feat: Expose more datascrubbing utils via cabi #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
approved these changes
Feb 11, 2020
| unsafe fn relay_convert_datascrubbing_config( | ||
| config: *const RelayStr | ||
| ) -> Result<RelayStr> { | ||
| let config: DataScrubbingConfig = serde_json::from_str((*config).as_str())?; |
There was a problem hiding this comment.
nit: Nomicon prefers turbofish here :)
untitaker
added a commit
to getsentry/sentry
that referenced
this pull request
Feb 19, 2020
Hard-depends on getsentry/relay#464 to make CI pass Related: getsentry/relay#469 get_event_enhancers now runs before scrubbing, and get_event_preprocessors after. All of our stacktrace processing happens in enhancers and stacktrace plugins. I am making the assumption here that sessionstack data should not be scrubbed.
priscilawebdev
pushed a commit
to getsentry/sentry
that referenced
this pull request
Feb 20, 2020
Hard-depends on getsentry/relay#464 to make CI pass Related: getsentry/relay#469 get_event_enhancers now runs before scrubbing, and get_event_preprocessors after. All of our stacktrace processing happens in enhancers and stacktrace plugins. I am making the assumption here that sessionstack data should not be scrubbed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.