Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ref: Make processing-relevant filepaths strippable #469

Merged
merged 7 commits into from
Feb 18, 2020
Merged

ref: Make processing-relevant filepaths strippable #469

merged 7 commits into from
Feb 18, 2020

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Feb 12, 2020 •
edited by jan-auer
Loading

See code comment in PII processor for description.

In NativeImagePaths we must not strip the file's basename because that would break
processing.

We pop the basename from the end of the string, call process_string and push the
basename again.

The ranges in Meta should still be right as long as we only pop/push from the end of the
string. If we decide that we need to preserve anything other than suffixes all PII
tooltips/annotations are potentially wrong.

Taking suggestions for better name of NativeImagePath.

@untitaker untitaker requested review from mitsuhiko and a team February 12, 2020 20:02
@untitaker untitaker mentioned this pull request Feb 14, 2020
Merged
@untitaker untitaker merged commit 278c145 into master Feb 18, 2020
@untitaker untitaker deleted the ref/debug-meta-stripping branch February 18, 2020 13:10
untitaker added a commit to getsentry/sentry that referenced this pull request Feb 19, 2020
@untitaker
feat: Datascrubbing after processing (#17054)
b04f0cf 
Hard-depends on getsentry/relay#464 to make CI pass
Related: getsentry/relay#469

get_event_enhancers now runs before scrubbing, and get_event_preprocessors after. All of our stacktrace processing happens in enhancers and stacktrace plugins.

I am making the assumption here that sessionstack data should not be scrubbed.
priscilawebdev pushed a commit to getsentry/sentry that referenced this pull request Feb 20, 2020
@untitaker
feat: Datascrubbing after processing (#17054)
c259c9e 
Hard-depends on getsentry/relay#464 to make CI pass
Related: getsentry/relay#469

get_event_enhancers now runs before scrubbing, and get_event_preprocessors after. All of our stacktrace processing happens in enhancers and stacktrace plugins.

I am making the assumption here that sessionstack data should not be scrubbed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mitsuhiko mitsuhiko mitsuhiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@untitaker @mitsuhiko