chore(deps): Upgrade to Vitest 2.1.8 and Vite 5.4.11 #14971
+337
−2,062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Jan 10, 2025
packages/sveltekit/package.json
Outdated
| @@ -53,7 +53,7 @@ | |||
| "@babel/types": "7.20.7", | |||
There was a problem hiding this comment.
this seems to fail when building now. I tried locally, and just removing the @babel/types dependency seems to "fix" this - can you try adjust it like this?
There was a problem hiding this comment.
Super weird! Things build locally for me correctly. Perhaps this is Yarn v1 not correctly layout things out on disk? I've run into that before. Let me start from a fresh repo and see if I can reproduce and fix.
There was a problem hiding this comment.
I unpinned @babel/types in 40bbc53 to allow a newer version to be used.
The build succeeded after the following:
rm -rf packages/*/node_modules
rm -rf node_modules
rm -rf .nxcache
yarn
yarn buildLet's see if CI is happy with this.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #14968. All the tests passed with zero modification!