feat(ci): Run yarn-deduplicate in CI

[nwalters512]

This PR introduces a CI step to use yarn-deduplicate to ensure that packages are maximally deduped. This makes version upgrades easier and minimizes the amount of packages that need to be installed by Yarn.

I added this to the lint job, as that seemed the best place for it. Happy to move it elsewhere if desired.

Related to #14968.

[nwalters512]

@AbhiPrasad 👋 do you have any interest in merging this? I think it'll be a net positive for the project and should make it easier to keep dependencies up-to-date.

[AbhiPrasad]

Hey @nwalters512 sorry for the delay! was on vacation and then a bunch of other things came up.

I agree this is a net positive, just need to find some time to set aside to merge it in and update team process stuff for us internally.

[lforst]

E2E tests do not seem to like the deduplication. Will close for now.

[lforst]

It's probably an issue with how we defined deps in our packages but not sure.

[lforst]

Nvm, seems to fail on develop too

[nwalters512]

@lforst one potential way to narrow down the issue is to dedupe dependencies one-by-one in separate PRs until we find the one that breaks the E2E tests (currently seems to just be nextjs-13). I'd be happy to open those PRs. Unfortunately, this is difficult for me to test localls, as I can't even get the E2E tests to pass locally on the develop branch.

[lforst]

@nwalters512 I'd love to merge this but I can't justify spending time on it. None of this is user facing unfortunately.

[nwalters512]

@lforst understood, hence my offer to continue driving this forward myself. If you don't even want to spend time reviewing other dependency bump/dedupe PRs, I'd understand that too though.

[lforst]

@nwalters512 Oh if you manage to make the tests pass please go ahead 😄 I they pass we can merge. I just won't spend time on it any longer I think.

[nwalters512]

I'll see what I can do! The fact that just changing dependencies within their semver-compatible versions can make tests fail is a bit of a red flag, so there's probably some interesting deeper issue here.

[nwalters512]

First round of this is #15639, all tests pass after deduping all @babel dependencies.

[nwalters512]

I was able to get the nextjs-13 tests passing locally for me on develop. They start failing with a timeout as soon as rollup is deduplicated:

  1) [chromium] › tests/client/pages-dir-pageload.test.ts:50:5 › should create a pageload transaction with correct name when an error occurs in getServerSideProps 

    Test timeout of 30000ms exceeded.

[nwalters512]

I've narrowed it down to rollup@4.34.0. Things work with v4.33.0, and fail with v4.34.0, the next version that was published.

[nwalters512]

I believe Rollup is stripping properties out of an object when it shouldn't be.

Here's the relevant code:

sentry-javascript/packages/nextjs/src/config/templates/pageWrapperTemplate.ts

Lines 29 to 33 in 48ed271

	const getInitialPropsWrappers: Record<string, any> = {
	'/_app': Sentry.wrapAppGetInitialPropsWithSentry,
	'/_document': Sentry.wrapDocumentGetInitialPropsWithSentry,
	'/_error': Sentry.wrapErrorGetInitialPropsWithSentry,
	};

Here's how it looks when things work (old version of Rollup):

const getInitialPropsWrappers = {
  '/_app': Sentry.wrapAppGetInitialPropsWithSentry,
  '/_document': Sentry.wrapDocumentGetInitialPropsWithSentry,
  '/_error': Sentry.wrapErrorGetInitialPropsWithSentry,
};

And when things break (newest version of Rollup):

const getInitialPropsWrappers = {
  };

[nwalters512]

I opened #15651 to independently upgrade to the latest version of Rollup and fix the bug that it caused in the @sentry/nextjs package.