feat(core): Add types for logs protocol and envelope #15530
Merged
+74
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
lforst and
chargome
and removed request for
a team
size-limit report 📦
|
3 tasks
|
I have 0 clue why size-limit is unhappy. Makes me lose trust in it tbh. |
chargome
approved these changes
Feb 28, 2025
| * The severity level of the log. | ||
| * | ||
| * Allowed values are, from highest to lowest: | ||
| * `critical`, `fatal`, `error`, `warn`, `info`, `debug`, `trace`. |
There was a problem hiding this comment.
Can you remind me what level trace would be used for?
There was a problem hiding this comment.
This is taken from the OTEL spec: https://opentelemetry.io/docs/specs/otel/logs/data-model/#severity-fields
According to their spec, trace is used for:
A fine-grained debugging event. Typically disabled in default configurations.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15526
Based on the work in #15442, we add definitions for the logs protocol and envelope to the JavaScript SDKs.
Relay data category: https://github.com/getsentry/relay/blob/e36886a98c89af645e5c0d2109657deafa25d902/relay-server/src/envelope.rs#L182
Relay log protocol: https://github.com/getsentry/relay/blob/ad04adf6d6756c4e36328c8217bea0ee01f289ec/relay-event-schema/src/protocol/ourlog.rs#L12