-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(core): Add types for logs protocol and envelope #15530
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
export type LogSeverityLevel = 'trace' | 'debug' | 'info' | 'warn' | 'error' | 'fatal' | 'critical'; | ||
|
||
export type LogAttributeValueType = | ||
| { | ||
stringValue: string; | ||
} | ||
| { | ||
intValue: number; | ||
} | ||
| { | ||
boolValue: boolean; | ||
} | ||
| { | ||
doubleValue: number; | ||
}; | ||
|
||
export type LogAttribute = { | ||
key: string; | ||
value: LogAttributeValueType; | ||
}; | ||
|
||
export interface Log { | ||
/** | ||
* The severity level of the log. | ||
* | ||
* Allowed values are, from highest to lowest: | ||
* `critical`, `fatal`, `error`, `warn`, `info`, `debug`, `trace`. | ||
* | ||
* The log level changes how logs are filtered and displayed. | ||
* Critical level logs are emphasized more than trace level logs. | ||
*/ | ||
severityText?: LogSeverityLevel; | ||
|
||
/** | ||
* The severity number - generally higher severity are levels like 'error' and lower are levels like 'debug' | ||
*/ | ||
severityNumber?: number; | ||
|
||
/** | ||
* The trace ID for this log | ||
*/ | ||
traceId?: string; | ||
|
||
/** | ||
* The message to be logged - for example, 'hello world' would become a log like '[INFO] hello world' | ||
*/ | ||
body: { | ||
stringValue: string; | ||
}; | ||
|
||
/** | ||
* Arbitrary structured data that stores information about the log - e.g., userId: 100. | ||
*/ | ||
attributes?: LogAttribute[]; | ||
|
||
/** | ||
* This doesn't have to be explicitly specified most of the time. If you need to set it, the value | ||
* is the number of seconds since midnight on January 1, 1970 ("unix epoch time") | ||
* | ||
* @summary A timestamp representing when the log occurred. | ||
* @link https://develop.sentry.dev/sdk/event-payloads/breadcrumbs/#:~:text=is%20info.-,timestamp,-(recommended) | ||
*/ | ||
timeUnixNano?: string; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remind me what level
trace
would be used for?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is taken from the OTEL spec: https://opentelemetry.io/docs/specs/otel/logs/data-model/#severity-fields
According to their spec,
trace
is used for: