node: implement new continuous profiling API spec #15635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
commented
Mar 11, 2025
JonasBa
commented
Mar 11, 2025
JonasBa
changed the title
JonasBa
changed the title
AbhiPrasad
reviewed
Mar 17, 2025
There was a problem hiding this comment.
In a follow-up PR, could we update the node-profiling e2e tests? https://github.com/getsentry/sentry-javascript/tree/develop/dev-packages/e2e-tests/test-applications
This is just to make sure that we don't accidentally mess with the new APIs or typescript types in our different builds.
| @@ -26,6 +26,8 @@ export interface BaseNodeOptions { | |||
|
|
|||
| /** | |||
| * Sets profiling sample rate when @sentry/profiling-node is installed | |||
| * | |||
| * @deprecated | |||
There was a problem hiding this comment.
We should add migration docs for this and profilesSampler.
AbhiPrasad
approved these changes
Mar 18, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #15636 (comment) and deprecates the old Sentry.profiler.start and Sentry.profiler.stop calls