Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf(core): Add short-circuits to eventFilters integration #15752

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

lforst
Copy link
Member

@lforst lforst commented Mar 20, 2025

Ref: #15725

  • Only does the options merging once
  • Adds short circuiting for event types to avoid doing things multiple times/unnecessarily

@lforst lforst requested review from mydea and chargome March 20, 2025 11:30
Copy link
Contributor

github-actions bot commented Mar 20, 2025

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.29 KB +0.07% +15 B 🔺
@sentry/browser - with treeshaking flags 23.11 KB +0.09% +19 B 🔺
@sentry/browser (incl. Tracing) 36.34 KB +0.06% +22 B 🔺
@sentry/browser (incl. Tracing, Replay) 73.51 KB +0.02% +13 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.94 KB +0.03% +14 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 78.15 KB +0.03% +20 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 90.71 KB +0.03% +19 B 🔺
@sentry/browser (incl. Feedback) 40.43 KB +0.03% +9 B 🔺
@sentry/browser (incl. sendFeedback) 27.93 KB +0.09% +23 B 🔺
@sentry/browser (incl. FeedbackAsync) 32.73 KB +0.07% +23 B 🔺
@sentry/react 25.1 KB +0.07% +16 B 🔺
@sentry/react (incl. Tracing) 38.26 KB +0.09% +32 B 🔺
@sentry/vue 27.52 KB +0.02% +5 B 🔺
@sentry/vue (incl. Tracing) 38.04 KB +0.08% +30 B 🔺
@sentry/svelte 23.33 KB +0.11% +26 B 🔺
CDN Bundle 24.52 KB +0.14% +35 B 🔺
CDN Bundle (incl. Tracing) 36.38 KB +0.04% +14 B 🔺
CDN Bundle (incl. Tracing, Replay) 71.41 KB +0.04% +23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 76.61 KB +0.05% +39 B 🔺
CDN Bundle - uncompressed 71.68 KB +0.17% +119 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 108.06 KB +0.11% +119 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.32 KB +0.06% +119 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.88 KB +0.06% +119 B 🔺
@sentry/nextjs (client) 39.56 KB +0.1% +39 B 🔺
@sentry/sveltekit (client) 36.76 KB +0.09% +31 B 🔺
@sentry/node 142.64 KB +0.02% +22 B 🔺
@sentry/node - without tracing 96.03 KB +0.03% +26 B 🔺
@sentry/aws-serverless 120.4 KB +0.03% +30 B 🔺

View base workflow run

@lforst
Copy link
Member Author

lforst commented Mar 20, 2025

Just profiled this again and this literally eliminates 5% of SDK overhead lol

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

Co-authored-by: Francesco Gringl-Novy <francesco.novy@sentry.io>
@lforst lforst merged commit 46eff72 into develop Mar 20, 2025
152 checks passed
@lforst lforst deleted the lforst-event-filters-perf-improvments branch March 20, 2025 14:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants