Skip to content

test(celery): Stop using configure_scope #3348

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

szokeasaurusrex
Copy link
Member

Use Scope.get_isolation_scope instead.

Ref #3344

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.78%. Comparing base (18015e9) to head (ab408f2).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3348   +/-   ##
=======================================
  Coverage   79.78%   79.78%           
=======================================
  Files         133      133           
  Lines       14319    14319           
  Branches     3009     3009           
=======================================
  Hits        11424    11424           
- Misses       2071     2074    +3     
+ Partials      824      821    -3     

see 5 files with indirect coverage changes

@szokeasaurusrex szokeasaurusrex linked an issue Jul 26, 2024 that may be closed by this pull request
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/configure_scope-0 branch from ab408f2 to afca706 Compare July 26, 2024 11:49
Use `Scope.get_isolation_scope` instead.

Ref #3344
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/configure_scope-0 branch from afca706 to cc0ee38 Compare July 26, 2024 11:52
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@szokeasaurusrex szokeasaurusrex merged commit cc0ee38 into master Jul 26, 2024
126 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/configure_scope-0 branch July 26, 2024 13:10
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
Use `Scope.get_isolation_scope` instead.

Ref getsentry#3344
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using sentry_sdk.configure_scope in SDK
2 participants