Skip to content

feat: Add __notes__ support #3620

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Oct 8, 2024
Merged

feat: Add __notes__ support #3620

merged 3 commits into from
Oct 8, 2024

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Oct 7, 2024

Supersedes #3056
Closes #3050


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

Copy link

codecov bot commented Oct 7, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
13713 1 13712 2021
View the full list of 1 ❄️ flaky tests
tests.profiler.test_continuous_profiler test_continuous_profiler_manual_start_and_stop[experiment-thread]

Flake rate in main: 95.00% (Passed 6 times, Failed 114 times)

Stack Traces | 0.197s run time
tests/profiler/test_continuous_profiler.py:267: in test_continuous_profiler_manual_start_and_stop
    assert_single_transaction_with_profile_chunks(envelopes, thread)
tests/profiler/test_continuous_profiler.py:110: in assert_single_transaction_with_profile_chunks
    assert len(items["profile_chunk"]) > 0
E   assert 0 > 0
E    +  where 0 = len([])

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! nice!

@szokeasaurusrex szokeasaurusrex merged commit 2d2e548 into master Oct 8, 2024
135 of 136 checks passed
@szokeasaurusrex szokeasaurusrex deleted the add-notes-support branch October 8, 2024 08:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for add_note() / __notes__
3 participants