-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(profiling): Change continuous profile buffer size #3987
chore(profiling): Change continuous profile buffer size #3987
Conversation
…ffer size This lowers the sampling frequency of continous profiles to 21Hz and increases the buffer size to 1 minute.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3987 +/- ##
==========================================
+ Coverage 80.16% 80.19% +0.03%
==========================================
Files 139 139
Lines 15403 15403
Branches 2597 2597
==========================================
+ Hits 12348 12353 +5
+ Misses 2211 2206 -5
Partials 844 844
|
Holding off on merging this until I confirm a few things. |
…o/chore/change-continuous-profile-sampling-frequency-and-buffer-size
Only bumping the buffer size to 1min and keeping the sampling frequency at 101hz. Reducing the sampling frequency on the SDK will cause pains that are difficult to undo. |
…ling-frequency-and-buffer-size
This
lowers the sampling frequency of continuous profiles to 21Hz andincreases the buffer size to 1 minute to match the desired settings for continuous profiling.