Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(profiling): Change continuous profile buffer size #3987

Merged
merged 6 commits into from
Feb 3, 2025
Merged

chore(profiling): Change continuous profile buffer size #3987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
083e78b
chore(profiling): Change continuous profile sampling frequency and bu…
Zylphrex Jan 21, 2025
a85382c
Merge branch 'master' of github.com:getsentry/sentry-python into txia…
Zylphrex Jan 31, 2025
98aec9b
revert sampling frequency
Zylphrex Jan 31, 2025
4bcc895
Merge branch 'master' into txiao/chore/change-continuous-profile-samp…
Zylphrex Feb 3, 2025
89016af
bump
Zylphrex Feb 3, 2025
2f497c3
fix mypy comment
Zylphrex Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sentry_sdk/profiler/continuous_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ def teardown(self):
self.buffer = None


PROFILE_BUFFER_SECONDS = 10
PROFILE_BUFFER_SECONDS = 60


class ProfileBuffer:
Expand Down
2 changes: 1 addition & 1 deletion sentry_sdk/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ def _request(

try:
import httpcore
import h2 # type: ignore # noqa: F401
import h2 # noqa: F401
except ImportError:
# Sorry, no Http2Transport for you
class Http2Transport(HttpTransport):
Expand Down
6 changes: 3 additions & 3 deletions tests/profiler/test_continuous_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def test_continuous_profiler_auto_start_and_manual_stop(

with sentry_sdk.start_transaction(name="profiling"):
with sentry_sdk.start_span(op="op"):
time.sleep(0.05)
time.sleep(0.1)

assert_single_transaction_with_profile_chunks(envelopes, thread)

Expand All @@ -211,7 +211,7 @@ def test_continuous_profiler_auto_start_and_manual_stop(

with sentry_sdk.start_transaction(name="profiling"):
with sentry_sdk.start_span(op="op"):
time.sleep(0.05)
time.sleep(0.1)

assert_single_transaction_without_profile_chunks(envelopes)

Expand All @@ -221,7 +221,7 @@ def test_continuous_profiler_auto_start_and_manual_stop(

with sentry_sdk.start_transaction(name="profiling"):
with sentry_sdk.start_span(op="op"):
time.sleep(0.05)
time.sleep(0.1)

assert_single_transaction_with_profile_chunks(envelopes, thread)

Expand Down
Loading