Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Capture app start errors before JS #4472

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

feat: Capture app start errors before JS #4472

wants to merge 22 commits into from

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Jan 21, 2025 •
edited
Loading

Create merge commit. Do not squash.

This PR contains reviewed intermediate commits for capturing error before JS start feature.

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against e935360

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 374.17 ms 362.06 ms -12.11 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5fe8312+dirty 389.98 ms 421.46 ms 31.48 ms
7bc4d75+dirty 420.96 ms 472.25 ms 51.29 ms
60d7316+dirty 475.43 ms 535.26 ms 59.84 ms
9dabcce+dirty 359.66 ms 430.73 ms 71.08 ms
b6f8ea2+dirty 397.51 ms 457.40 ms 59.88 ms
52c0562+dirty 401.23 ms 435.65 ms 34.42 ms
457e29f+dirty 591.49 ms 612.96 ms 21.47 ms
6a667d6+dirty 419.89 ms 476.58 ms 56.69 ms
c639edf+dirty 363.39 ms 414.78 ms 51.39 ms
fc150fe+dirty 409.55 ms 407.37 ms -2.18 ms

App size

Revision Plain With Sentry Diff
5fe8312+dirty 7.15 MiB 8.38 MiB 1.23 MiB
7bc4d75+dirty 7.15 MiB 8.35 MiB 1.20 MiB
60d7316+dirty 7.15 MiB 8.38 MiB 1.22 MiB
9dabcce+dirty 7.15 MiB 8.37 MiB 1.22 MiB
b6f8ea2+dirty 7.15 MiB 8.38 MiB 1.23 MiB
52c0562+dirty 7.15 MiB 8.39 MiB 1.24 MiB
457e29f+dirty 7.15 MiB 8.10 MiB 981.29 KiB
6a667d6+dirty 7.15 MiB 8.38 MiB 1.23 MiB
c639edf+dirty 7.15 MiB 8.35 MiB 1.20 MiB
fc150fe+dirty 7.15 MiB 8.38 MiB 1.23 MiB

Previous results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
5625ce7+dirty 358.15 ms 416.65 ms 58.50 ms
b6d933c+dirty 398.43 ms 456.62 ms 58.19 ms
8d0daf6+dirty 393.58 ms 394.84 ms 1.26 ms
18a5066+dirty 370.06 ms 414.10 ms 44.04 ms
1a89392+dirty 425.56 ms 530.65 ms 105.09 ms
b75148e+dirty 428.91 ms 461.26 ms 32.35 ms
454f971+dirty 439.04 ms 423.88 ms -15.16 ms
208f4af+dirty 346.93 ms 402.77 ms 55.84 ms
555070f+dirty 388.25 ms 424.44 ms 36.19 ms

App size

Revision Plain With Sentry Diff
5625ce7+dirty 7.15 MiB 8.38 MiB 1.23 MiB
b6d933c+dirty 7.15 MiB 8.38 MiB 1.23 MiB
8d0daf6+dirty 7.15 MiB 8.38 MiB 1.23 MiB
18a5066+dirty 7.15 MiB 8.38 MiB 1.23 MiB
1a89392+dirty 7.15 MiB 8.38 MiB 1.23 MiB
b75148e+dirty 7.15 MiB 8.38 MiB 1.23 MiB
454f971+dirty 7.15 MiB 8.38 MiB 1.23 MiB
208f4af+dirty 7.15 MiB 8.38 MiB 1.23 MiB
555070f+dirty 7.15 MiB 8.38 MiB 1.23 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.55 ms 1217.23 ms -1.32 ms
Size 2.63 MiB 3.74 MiB 1.11 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 1273.28 ms 1276.68 ms 3.40 ms
8ab11b6+dirty 1203.23 ms 1206.02 ms 2.79 ms
8b86336+dirty 1219.38 ms 1230.73 ms 11.36 ms
1c9e040+dirty 1226.02 ms 1221.06 ms -4.96 ms
83f6f6c+dirty 1218.33 ms 1220.27 ms 1.93 ms
5bb8d5f+dirty 1235.47 ms 1237.39 ms 1.92 ms
7e87527+dirty 1209.85 ms 1216.31 ms 6.46 ms
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
9672577+dirty 1230.46 ms 1237.43 ms 6.97 ms
6a667d6+dirty 1209.23 ms 1210.85 ms 1.62 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 2.36 MiB 2.88 MiB 531.94 KiB
8ab11b6+dirty 2.36 MiB 3.11 MiB 759.83 KiB
8b86336+dirty 2.63 MiB 3.68 MiB 1.05 MiB
1c9e040+dirty 2.63 MiB 3.69 MiB 1.06 MiB
83f6f6c+dirty 2.36 MiB 3.10 MiB 759.79 KiB
5bb8d5f+dirty 2.36 MiB 2.92 MiB 570.22 KiB
7e87527+dirty 2.63 MiB 3.69 MiB 1.05 MiB
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
9672577+dirty 2.63 MiB 3.70 MiB 1.06 MiB
6a667d6+dirty 2.63 MiB 3.70 MiB 1.06 MiB

Previous results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
555070f+dirty 1213.59 ms 1217.79 ms 4.20 ms
b6d933c+dirty 1217.71 ms 1220.58 ms 2.87 ms
b75148e+dirty 1221.53 ms 1220.85 ms -0.68 ms
454f971+dirty 1220.55 ms 1225.82 ms 5.27 ms
8d0daf6+dirty 1230.90 ms 1233.16 ms 2.27 ms
208f4af+dirty 1209.44 ms 1217.13 ms 7.70 ms
18a5066+dirty 1218.00 ms 1212.27 ms -5.73 ms
5625ce7+dirty 1226.98 ms 1217.77 ms -9.21 ms
1a89392+dirty 1220.12 ms 1216.69 ms -3.43 ms

App size

Revision Plain With Sentry Diff
555070f+dirty 2.63 MiB 3.69 MiB 1.05 MiB
b6d933c+dirty 2.63 MiB 3.70 MiB 1.06 MiB
b75148e+dirty 2.63 MiB 3.69 MiB 1.06 MiB
454f971+dirty 2.63 MiB 3.74 MiB 1.11 MiB
8d0daf6+dirty 2.63 MiB 3.74 MiB 1.11 MiB
208f4af+dirty 2.63 MiB 3.69 MiB 1.05 MiB
18a5066+dirty 2.63 MiB 3.70 MiB 1.06 MiB
5625ce7+dirty 2.63 MiB 3.70 MiB 1.06 MiB
1a89392+dirty 2.63 MiB 3.70 MiB 1.06 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.49 ms 1224.29 ms -1.20 ms
Size 3.19 MiB 4.30 MiB 1.12 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 1249.94 ms 1254.80 ms 4.86 ms
8ab11b6+dirty 1222.91 ms 1216.08 ms -6.83 ms
8b86336+dirty 1236.26 ms 1235.00 ms -1.26 ms
1c9e040+dirty 1214.84 ms 1222.06 ms 7.22 ms
83f6f6c+dirty 1232.02 ms 1229.15 ms -2.87 ms
5bb8d5f+dirty 1215.04 ms 1217.52 ms 2.48 ms
7e87527+dirty 1223.83 ms 1222.90 ms -0.94 ms
80b2ce3+dirty 1245.12 ms 1262.04 ms 16.92 ms
9672577+dirty 1215.21 ms 1214.08 ms -1.13 ms
6a667d6+dirty 1233.27 ms 1235.16 ms 1.89 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 2.92 MiB 3.44 MiB 535.26 KiB
8ab11b6+dirty 2.92 MiB 3.67 MiB 772.38 KiB
8b86336+dirty 3.19 MiB 4.25 MiB 1.06 MiB
1c9e040+dirty 3.19 MiB 4.25 MiB 1.07 MiB
83f6f6c+dirty 2.92 MiB 3.67 MiB 772.37 KiB
5bb8d5f+dirty 2.92 MiB 3.48 MiB 575.85 KiB
7e87527+dirty 3.19 MiB 4.25 MiB 1.06 MiB
80b2ce3+dirty 2.92 MiB 3.40 MiB 492.75 KiB
9672577+dirty 3.19 MiB 4.26 MiB 1.08 MiB
6a667d6+dirty 3.19 MiB 4.26 MiB 1.08 MiB

Previous results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
555070f+dirty 1223.61 ms 1227.57 ms 3.96 ms
b6d933c+dirty 1228.02 ms 1235.32 ms 7.30 ms
b75148e+dirty 1202.72 ms 1212.04 ms 9.32 ms
454f971+dirty 1233.51 ms 1239.18 ms 5.67 ms
8d0daf6+dirty 1227.80 ms 1236.83 ms 9.03 ms
208f4af+dirty 1213.08 ms 1223.82 ms 10.73 ms
18a5066+dirty 1244.20 ms 1251.54 ms 7.34 ms
5625ce7+dirty 1219.73 ms 1223.80 ms 4.07 ms
1a89392+dirty 1229.00 ms 1234.78 ms 5.78 ms

App size

Revision Plain With Sentry Diff
555070f+dirty 3.19 MiB 4.25 MiB 1.06 MiB
b6d933c+dirty 3.19 MiB 4.26 MiB 1.08 MiB
b75148e+dirty 3.19 MiB 4.25 MiB 1.07 MiB
454f971+dirty 3.19 MiB 4.31 MiB 1.12 MiB
8d0daf6+dirty 3.19 MiB 4.30 MiB 1.12 MiB
208f4af+dirty 3.19 MiB 4.25 MiB 1.06 MiB
18a5066+dirty 3.19 MiB 4.26 MiB 1.08 MiB
5625ce7+dirty 3.19 MiB 4.26 MiB 1.08 MiB
1a89392+dirty 3.19 MiB 4.26 MiB 1.08 MiB

@antonis @krystofwoldrich
ref(android): Extracts Android native initialization to standalone st…
2cb7eb2 
…ructures (#4445)

* Extract Android SDK Init

* Update tests

* Adds changelog

* Fix lint issues

* Rename RNSentryStart instance for clarity

* Converts RNSentryStart to utility class

* Update CHANGELOG.md

---------

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 397.17 ms 415.72 ms 18.55 ms
Size 17.75 MiB 20.11 MiB 2.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
43e66e0 373.32 ms 366.57 ms -6.75 ms
3f05680 397.91 ms 405.65 ms 7.74 ms
7e87527 425.56 ms 407.64 ms -17.93 ms
c639edf 466.48 ms 489.57 ms 23.09 ms
8d251c2 464.41 ms 456.34 ms -8.07 ms
30189be 440.46 ms 435.60 ms -4.85 ms
d8e8c67 448.79 ms 438.70 ms -10.09 ms
fe13591 478.92 ms 480.84 ms 1.92 ms
3261206 476.43 ms 465.96 ms -10.48 ms

App size

Revision Plain With Sentry Diff
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
43e66e0 17.74 MiB 20.09 MiB 2.35 MiB
3f05680 17.75 MiB 20.11 MiB 2.37 MiB
7e87527 17.75 MiB 20.11 MiB 2.37 MiB
c639edf 17.74 MiB 20.08 MiB 2.34 MiB
8d251c2 17.75 MiB 20.11 MiB 2.37 MiB
30189be 17.75 MiB 20.11 MiB 2.36 MiB
d8e8c67 17.74 MiB 20.10 MiB 2.36 MiB
fe13591 17.74 MiB 20.07 MiB 2.34 MiB
3261206 17.75 MiB 20.11 MiB 2.37 MiB

Previous results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
18a5066 427.89 ms 436.47 ms 8.57 ms
555070f 438.67 ms 428.30 ms -10.37 ms
8d0daf6 422.36 ms 449.40 ms 27.04 ms
454f971 436.27 ms 478.76 ms 42.48 ms
b6d933c 442.52 ms 461.82 ms 19.30 ms
b75148e 440.04 ms 421.36 ms -18.68 ms
208f4af 439.23 ms 427.31 ms -11.92 ms
1a89392 412.59 ms 424.69 ms 12.10 ms
5625ce7 476.74 ms 488.24 ms 11.50 ms

App size

Revision Plain With Sentry Diff
18a5066 17.75 MiB 20.11 MiB 2.37 MiB
555070f 17.75 MiB 20.11 MiB 2.37 MiB
8d0daf6 17.75 MiB 20.11 MiB 2.36 MiB
454f971 17.75 MiB 20.11 MiB 2.37 MiB
b6d933c 17.75 MiB 20.11 MiB 2.37 MiB
b75148e 17.75 MiB 20.11 MiB 2.37 MiB
208f4af 17.75 MiB 20.11 MiB 2.37 MiB
1a89392 17.75 MiB 20.11 MiB 2.37 MiB
5625ce7 17.75 MiB 20.11 MiB 2.37 MiB

@antonis antonis mentioned this pull request Jan 28, 2025
Open
10 tasks
krystofwoldrich and others added 16 commits February 3, 2025 11:55
@krystofwoldrich
feat: Automatically load sentry.options.json file (#4476)
22a5f81
@antonis
feat(experimental): Initialize Android SDK from json configuration (#…
a1cb36d 
…4451)
@krystofwoldrich
Merge branch 'main' into capture-app-start-errors
95c36ef
@krystofwoldrich
misc: Add sentry.options.json example to the changelog (#4509)
14fe05d
@krystofwoldrich
feat(init): Load options from sentry.options.json in JS (#4510)
15a7e6d
@getsentry-bot
release: 6.7.0-alpha.0
b9ec093
Merge branch 'release/6.7.0-alpha.0' into capture-app-start-errors
dbdd4b5
@krystofwoldrich
misc(sample): Change RN Sample to use native file init by default (#4522
b947d7f 
)
@krystofwoldrich
chore(sample-rn): Remove duplicate init options from code (#4532)
6b08b9a
@krystofwoldrich
chore(sample-rn): Always use fhe file option (including auto init) (#…
a7ffa1f 
…4533)
@krystofwoldrich
internal(sample-rn): Add Detox for integration/e2e tests of the rn sa…
28cf7b4 
…mple (#4535)
@krystofwoldrich
internal(sample-rn): Add header and message envelope tests (#4536)
cf00d4d
@krystofwoldrich
Merge remote-tracking branch 'origin/main' into capture-app-start-errors
b754aa3
@krystofwoldrich
fix(sample-e2e): Fix type errors missing sentry/core and afterAll (#4564
0bf6636 
)
@krystofwoldrich
Merge remote-tracking branch 'origin/main' into capture-app-start-errors
0f5cd7d
@krystofwoldrich
chore(samples): Add package scripts for native builds, dsn and testing (
e935360 
#4561)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman will be requested when the pull request is marked ready for review lucas-zimerman is a code owner

@antonis antonis Awaiting requested review from antonis antonis will be requested when the pull request is marked ready for review antonis is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krystofwoldrich @antonis @getsentry-bot