Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore(deps): Bump Android SDK to v8.2.0 #4490

Open
wants to merge 28 commits into
base: v7
Choose a base branch
from
Open

chore(deps): Bump Android SDK to v8.2.0 #4490

wants to merge 28 commits into from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Jan 28, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

I've opened this PR to fix Android SDK v8.0.0 breakages and deprecations without interfering with the update-android.sh ci automation and to get a 2nd eye on the changes.

⚠️ The changes on this PR will conflict with the Android refactoring for the capture app start errors feature. I expect that porting the 5 changes/commits in the new implementation should be straightforward.

💡 Motivation and Context

Part of #4541

Migration guide from version 7.x to 8.0

Breakages

Deprecations

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 408.49 ms 400.63 ms -7.86 ms
Size 17.75 MiB 20.15 MiB 2.40 MiB

Previous results on branch: antonis/android-sdk-8

Startup times

Revision Plain With Sentry Diff
f107027 383.58 ms 407.79 ms 24.21 ms
48d1309 451.34 ms 470.70 ms 19.36 ms
9af1463 403.72 ms 386.56 ms -17.16 ms
43ce2a5 335.96 ms 352.66 ms 16.70 ms
13aaa0b 381.94 ms 491.94 ms 110.00 ms
f703940 437.08 ms 449.29 ms 12.21 ms
8f1e8e1 468.76 ms 462.81 ms -5.95 ms
516ff9a 449.94 ms 430.71 ms -19.22 ms

App size

Revision Plain With Sentry Diff
f107027 17.75 MiB 20.15 MiB 2.40 MiB
48d1309 17.75 MiB 20.15 MiB 2.40 MiB
9af1463 17.75 MiB 20.12 MiB 2.37 MiB
43ce2a5 17.75 MiB 20.13 MiB 2.38 MiB
13aaa0b 17.75 MiB 20.13 MiB 2.38 MiB
f703940 17.75 MiB 20.12 MiB 2.37 MiB
8f1e8e1 17.75 MiB 20.15 MiB 2.40 MiB
516ff9a 17.75 MiB 20.13 MiB 2.38 MiB

@antonis antonis marked this pull request as ready for review January 28, 2025 11:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 367.73 ms 371.16 ms 3.43 ms
Size 7.15 MiB 8.41 MiB 1.26 MiB

Previous results on branch: antonis/android-sdk-8

Startup times

Revision Plain With Sentry Diff
9af1463+dirty 287.04 ms 313.50 ms 26.46 ms
8f1e8e1+dirty 388.60 ms 424.30 ms 35.70 ms
f703940+dirty 350.96 ms 390.84 ms 39.88 ms
516ff9a+dirty 348.83 ms 389.59 ms 40.76 ms
48d1309+dirty 395.78 ms 408.06 ms 12.28 ms
f107027+dirty 390.89 ms 411.72 ms 20.83 ms
13aaa0b+dirty 382.52 ms 440.69 ms 58.17 ms
43ce2a5+dirty 412.87 ms 461.96 ms 49.08 ms

App size

Revision Plain With Sentry Diff
9af1463+dirty 7.15 MiB 8.39 MiB 1.24 MiB
8f1e8e1+dirty 7.15 MiB 8.41 MiB 1.26 MiB
f703940+dirty 7.15 MiB 8.39 MiB 1.24 MiB
516ff9a+dirty 7.15 MiB 8.39 MiB 1.24 MiB
48d1309+dirty 7.15 MiB 8.41 MiB 1.26 MiB
f107027+dirty 7.15 MiB 8.41 MiB 1.26 MiB
13aaa0b+dirty 7.15 MiB 8.39 MiB 1.24 MiB
43ce2a5+dirty 7.15 MiB 8.39 MiB 1.24 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1229.31 ms 1225.35 ms -3.96 ms
Size 3.19 MiB 4.31 MiB 1.12 MiB

Previous results on branch: antonis/android-sdk-8

Startup times

Revision Plain With Sentry Diff
8f1e8e1+dirty 1227.39 ms 1220.58 ms -6.81 ms
48d1309+dirty 1227.32 ms 1227.41 ms 0.09 ms
516ff9a+dirty 1236.90 ms 1232.92 ms -3.98 ms
f107027+dirty 1220.96 ms 1223.61 ms 2.65 ms
43ce2a5+dirty 1222.30 ms 1210.89 ms -11.40 ms
f703940+dirty 1227.41 ms 1221.96 ms -5.45 ms
13aaa0b+dirty 1227.24 ms 1233.71 ms 6.47 ms
9af1463+dirty 1217.24 ms 1215.55 ms -1.69 ms

App size

Revision Plain With Sentry Diff
8f1e8e1+dirty 3.19 MiB 4.26 MiB 1.08 MiB
48d1309+dirty 3.19 MiB 4.31 MiB 1.12 MiB
516ff9a+dirty 3.19 MiB 4.26 MiB 1.08 MiB
f107027+dirty 3.19 MiB 4.31 MiB 1.12 MiB
43ce2a5+dirty 3.19 MiB 4.27 MiB 1.08 MiB
f703940+dirty 3.19 MiB 4.25 MiB 1.07 MiB
13aaa0b+dirty 3.19 MiB 4.26 MiB 1.08 MiB
9af1463+dirty 3.19 MiB 4.25 MiB 1.07 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.32 ms 1234.36 ms 8.04 ms
Size 2.63 MiB 3.74 MiB 1.11 MiB

Previous results on branch: antonis/android-sdk-8

Startup times

Revision Plain With Sentry Diff
8f1e8e1+dirty 1225.67 ms 1236.16 ms 10.49 ms
48d1309+dirty 1228.70 ms 1223.89 ms -4.81 ms
516ff9a+dirty 1210.71 ms 1219.10 ms 8.40 ms
f107027+dirty 1225.02 ms 1232.50 ms 7.48 ms
43ce2a5+dirty 1228.81 ms 1221.27 ms -7.54 ms
f703940+dirty 1219.50 ms 1223.02 ms 3.52 ms
13aaa0b+dirty 1227.88 ms 1225.39 ms -2.49 ms
9af1463+dirty 1231.92 ms 1232.04 ms 0.12 ms

App size

Revision Plain With Sentry Diff
8f1e8e1+dirty 2.63 MiB 3.70 MiB 1.06 MiB
48d1309+dirty 2.63 MiB 3.74 MiB 1.11 MiB
516ff9a+dirty 2.63 MiB 3.70 MiB 1.06 MiB
f107027+dirty 2.63 MiB 3.74 MiB 1.11 MiB
43ce2a5+dirty 2.63 MiB 3.70 MiB 1.07 MiB
f703940+dirty 2.63 MiB 3.69 MiB 1.05 MiB
13aaa0b+dirty 2.63 MiB 3.70 MiB 1.06 MiB
9af1463+dirty 2.63 MiB 3.69 MiB 1.06 MiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from d2b541e to 0316113 Compare January 29, 2025 07:45
lucas-zimerman
lucas-zimerman approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are looking good! LGTM!

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Jan 30, 2025 •
edited
Loading

We should evaluate if it's okay to release this in a feature update, or wait for RN SDK v7.

Generally we don't have to do a major due to native SDK major, but we should confirm if minSdkVersion bump to 21 and others are not issue for min support RN version 0.65.

@antonis
Copy link
Collaborator Author

antonis commented Jan 30, 2025

We should evaluate if it's okay to release this in a feature update, or wait for RN SDK v7.

That's a good point @krystofwoldrich 👍
Though this version bump has a long changelog my understanding from the migration guide is that it is safe to bump since the changes needed on our side were minimal.
That said it would be nice to have a confirmation from the Android team.

Generally we don't have to do a major due to native SDK major, but we should confirm if minSdkVersion bump to 21 and others are not issue for min support RN version 0.65.

Currently the react native sdk defaults to minSdk 21 (though our gradle is not enforcing that).
Given that the version 21 bump has been communicated in our v5 migration guide this might not be blocking.

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 2 times, most recently from fd074dc to b8e6e0d Compare January 31, 2025 05:53
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from b8e6e0d to 246e13b Compare January 31, 2025 07:16
@antonis
Merge branch 'deps/scripts/update-android.sh' into antonis/android-sdk-8
0d54111 
# Conflicts:
#	CHANGELOG.md
#	packages/core/android/build.gradle
@antonis antonis changed the title chore(deps): Fixes Android SDK v8.0.0 breakages and deprecations chore(deps): Fixes Android SDK v8 breakages and deprecations Jan 31, 2025
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from 246e13b to 6f276a6 Compare January 31, 2025 16:32
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from 6f276a6 to ac72161 Compare February 3, 2025 07:16
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 5 times, most recently from 3879562 to fd22c71 Compare February 11, 2025 09:38
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from fd22c71 to 6d63629 Compare February 12, 2025 07:52
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 2 times, most recently from 275aa0d to 42052ef Compare February 12, 2025 12:40
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from 42052ef to 93220a5 Compare February 13, 2025 03:05
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from 93220a5 to 6895033 Compare February 14, 2025 09:15
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 4 times, most recently from 1f6a33c to ebea685 Compare February 18, 2025 08:16
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from ebea685 to d50515c Compare February 18, 2025 09:17
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 2 times, most recently from edf3857 to 8007f1b Compare February 19, 2025 10:32
@antonis antonis changed the base branch from deps/scripts/update-android.sh to v7 February 19, 2025 15:06
@antonis
Copy link
Collaborator Author

antonis commented Feb 19, 2025

@krystofwoldrich , @lucas-zimerman I've targeted v7 and this is ready for another pass 🙇

@antonis antonis changed the title chore(deps): Fixes Android SDK v8 breakages and deprecations chore(deps): Bump Android SDK to v8.2.0 Feb 20, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antonis @krystofwoldrich @lucas-zimerman @web-flow