ref(js): Factor button functionality #91763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-js-factor-button-functionality
branch
from
d28bc1c to
4a6ad58
Compare
TkDodo
reviewed
May 19, 2025
- Move `useButtonFunctionality` into it's own module, keeping index.tsx specifc to JUST what is required to render the Button, and not sharing anything with linkButton - Move common styles out of the index module into styles.tsx, renames index.chonk to styles.chonk as well. - Move common types into types.tsx - Renames `getChonkButtonStyles` to `DO_NOT_USE_getChonkButtonStyles` to match the `DO_NOT_USE_getButtonStyles`
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-js-factor-button-functionality
branch
from
4a6ad58 to
d244645
Compare
evanpurkhiser
commented
May 19, 2025
evanpurkhiser
commented
May 19, 2025
| } | ||
|
|
||
| export type ButtonProps = ButtonPropsWithoutAriaLabel | ButtonPropsWithAriaLabel; | ||
| export type {ButtonProps}; |
There was a problem hiding this comment.
Re-export as the canonical place to get these props
TkDodo
approved these changes
May 20, 2025
evanpurkhiser
deleted the
evanpurkhiser/ref-js-factor-button-functionality
branch
jan-auer
added a commit
that referenced
this pull request
May 20, 2025
* master: (58 commits) link: cleanup link (#91687) ref: create project_id index for organizationonboardingtask (#91918) storybook: smaller last edited (#91875) issues: fix chonk stacktrace alignment (#91891) alert: drop custom alert (#91892) insights: fix bar height (#91895) ref(span-buffer): Move max-memory-percentage to right CLI (#91924) ref(js): Factor button functionality (#91763) tests(resolve_groups): Clean up the tests (#91779) ref(span-buffer): Add backpressure (#91707) fix(nextjs-insights): project id is not passed to explore link (#91920) fix(crons): Floor seconds / microsecond on recorded dateClock (#91890) fix(uptime): Fix bug with the uptime_checks dataset in the events endpoint (#91824) ref: add state-only migration to reflect existing indexes in prod (#91901) ref: remove unnecssary metaclass (#91906) fix(stats): use data category title name (#91913) feat(issues): Add success messages to some actions (#91899) test(taskworker): Lower exec time (#91907) chore(aci): manually add spans for delayed workflow processing (#91908) chore(aci): remove uses of WorkflowFireHistory rollout columns (#91904) ...
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
- Move `useButtonFunctionality` into it's own module, keeping index.tsx specifc to JUST what is required to render the Button, and not sharing anything with linkButton - Move common styles out of the index module into styles.tsx, renames index.chonk to styles.chonk as well. - Move common types into types.tsx - Renames `getChonkButtonStyles` to `DO_NOT_USE_getChonkButtonStyles` to match the `DO_NOT_USE_getButtonStyles`
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
useButtonFunctionalityinto it's own module, keeping index.tsxspecifc to JUST what is required to render the Button, and not sharing
anything with linkButton
Move common styles out of the index module into styles.tsx, renames
index.chonk to styles.chonk as well.
Move common types into types.tsx
Renames
getChonkButtonStylestoDO_NOT_USE_getChonkButtonStylestomatch the
DO_NOT_USE_getButtonStyles