Skip to content

alert: drop custom alert #91892

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

alert: drop custom alert #91892

merged 2 commits into from
May 20, 2025

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented May 19, 2025

Fixes DE-33

Before
CleanShot 2025-05-19 at 15 53 24@2x

After
CleanShot 2025-05-19 at 15 54 53@2x

Fwiw, this was also quite broken in dark mode...
CleanShot 2025-05-19 at 15 53 17@2x

@JonasBa JonasBa requested a review from a team May 19, 2025 20:01
@JonasBa JonasBa requested review from a team as code owners May 19, 2025 20:01
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 19, 2025
Copy link
Contributor

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, using built-in primitives over custom things 🙌

@JonasBa JonasBa merged commit d1589b0 into master May 20, 2025
42 checks passed
@JonasBa JonasBa deleted the jb/issues/banner-chonk branch May 20, 2025 13:04
jan-auer added a commit that referenced this pull request May 20, 2025
* master: (58 commits)
  link: cleanup link (#91687)
  ref: create project_id index for organizationonboardingtask (#91918)
  storybook: smaller last edited (#91875)
  issues: fix chonk stacktrace alignment (#91891)
  alert: drop custom alert (#91892)
  insights: fix bar height (#91895)
  ref(span-buffer): Move max-memory-percentage to right CLI (#91924)
  ref(js): Factor button functionality (#91763)
  tests(resolve_groups): Clean up the tests (#91779)
  ref(span-buffer): Add backpressure (#91707)
  fix(nextjs-insights): project id is not passed to explore link (#91920)
  fix(crons): Floor seconds / microsecond on recorded dateClock (#91890)
  fix(uptime): Fix bug with the uptime_checks dataset in the events endpoint (#91824)
  ref: add state-only migration to reflect existing indexes in prod (#91901)
  ref: remove unnecssary metaclass (#91906)
  fix(stats): use data category title name (#91913)
  feat(issues): Add success messages to some actions (#91899)
  test(taskworker): Lower exec time (#91907)
  chore(aci): manually add spans for delayed workflow processing (#91908)
  chore(aci): remove uses of WorkflowFireHistory rollout columns (#91904)
  ...
andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants