Skip to content

deps: Update ahash to fix "unknown feature stdsimd" error. #5304

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

waywardmonkeys
Copy link
Contributor

@waywardmonkeys waywardmonkeys commented Feb 26, 2024

Rust has removed the stdsimd feature: rust-lang/rust#117372
This broke ahash for versions prior to 0.8.7: tkaitchuck/aHash#183

Connections

Description
Due to the above, the wgpu repository won't build with a nightly build of Rust.

Testing
wgpu can build with a nightly compiler.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Rust has removed the `stdsimd` feature: rust-lang/rust#117372
This broke `ahash` for versions prior to `0.8.7`: tkaitchuck/aHash#183
@waywardmonkeys waywardmonkeys requested a review from a team as a code owner February 26, 2024 08:06
@cwfitzgerald cwfitzgerald merged commit 177517a into gfx-rs:trunk Feb 26, 2024
@waywardmonkeys waywardmonkeys deleted the update-ahash-to-fix-recent-builds branch February 26, 2024 09:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants