Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update stdarch submodule #117372

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Update stdarch submodule #117372

merged 6 commits into from
Feb 5, 2024

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Oct 29, 2023

Splits up #27731 into multiple tracking issues.

Closes #27731

@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 29, 2023
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2023

The Miri subtree was changed

cc @rust-lang/miri

@Amanieu Amanieu marked this pull request as draft October 31, 2023 23:06
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

Amanieu added a commit to Amanieu/aHash that referenced this pull request Nov 1, 2023
This is blocking rust-lang/rust#117372, which replaces `stdsimd` with
more fine-grained features. However the auto-detection in aHash breaks
when bootstrapping Rust because it detects the `stdsimd` feature on the
old toolchain which is not present on the newly build libcore.

This PR removes the build-time detection of the `stdsimd` feature and
instead just uses the ARM AES intrinsics directly since they are now
stable, but only on AArch64.
@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2023
tkaitchuck pushed a commit to tkaitchuck/aHash that referenced this pull request Nov 10, 2023
* Remove build-time check for `stdsimd` feature

This is blocking rust-lang/rust#117372, which replaces `stdsimd` with
more fine-grained features. However the auto-detection in aHash breaks
when bootstrapping Rust because it detects the `stdsimd` feature on the
old toolchain which is not present on the newly build libcore.

This PR removes the build-time detection of the `stdsimd` feature and
instead just uses the ARM AES intrinsics directly since they are now
stable, but only on AArch64.

* Add nightly-arm-aes Cargo feature
@daxpedda
Copy link
Contributor

AHash just released a new version, so this should be unblocked now.

@Amanieu Amanieu marked this pull request as ready for review January 2, 2024 18:43
sarah-quinones pushed a commit to sarah-quinones/pulp that referenced this pull request Feb 8, 2024
…ly (#6)

* use newly introduced stdarch features for avx512 to compiler on nightly

see

rust-lang/rust#117372

* bump version to 0.18.7
paultag added a commit to KittyCAD/modeling-app that referenced this pull request Feb 22, 2024
Specifically, i'm hitting tkaitchuck/aHash#200
ahash FTBFS because of rust-lang/rust#117372
which is fixed in 0.8.7.

This rolls us forward which should fix future builds.
paultag added a commit to KittyCAD/modeling-app that referenced this pull request Feb 22, 2024
Specifically, i'm hitting tkaitchuck/aHash#200
ahash FTBFS because of rust-lang/rust#117372
which is fixed in 0.8.7.

This rolls us forward which should fix future builds.
waywardmonkeys added a commit to waywardmonkeys/wgpu that referenced this pull request Feb 26, 2024
Rust has removed the `stdsimd` feature: rust-lang/rust#117372
This broke `ahash` for versions prior to `0.8.7`: tkaitchuck/aHash#183
stupendoussuperpowers pushed a commit to stupendoussuperpowers/cargo that referenced this pull request Feb 28, 2024
Previous versions use the `stdsimd` nightly feature if it detects that
it is available (on a nightly toolchain). This will stop working once
rust-lang/rust#117372 is merged.
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Mar 8, 2024
…acrum

Update stdarch submodule

Splits up rust-lang#27731 into multiple tracking issues.

Closes rust-lang#27731
vadorovsky added a commit to vadorovsky/light-protocol that referenced this pull request May 1, 2024
The newest Rust nightly removed the `stdsimd` feature in favor of
more grained features (rust-lang/rust#117372).

However, the version of `ahash` we depend on, still requires that
feature. New release of `ahash` (0.8.7) contains a fix, but we can't
upgrade to it without upgrading Anchor.

Pinning Rust nightly seems to be the less intrusive solution for now.
clems4ever pushed a commit to clems4ever/hypergraph that referenced this pull request Nov 18, 2024
currently, cargo build generates the following error due to the removal
of stdsim: rust-lang/rust#117372
clems4ever pushed a commit to clems4ever/hypergraph that referenced this pull request Nov 18, 2024
currently, cargo build generates the following error due to the removal
of stdsim: rust-lang/rust#117372
clems4ever added a commit to clems4ever/hypergraph that referenced this pull request Nov 18, 2024
currently, cargo build generates the following error due to the removal
of stdsim: rust-lang/rust#117372
clems4ever added a commit to clems4ever/hypergraph that referenced this pull request Nov 18, 2024
currently, cargo build generates the following error due to the removal
of stdsim: rust-lang/rust#117372
clems4ever added a commit to clems4ever/hypergraph that referenced this pull request Nov 18, 2024
currently, cargo build generates the following error due to the removal
of stdsim: rust-lang/rust#117372
yamafaktory added a commit to yamafaktory/hypergraph that referenced this pull request Nov 19, 2024
* bump ahash crate to fix build

currently, cargo build generates the following error due to the removal
of stdsim: rust-lang/rust#117372

* fix clippy errors

* attempt to fix formatting

* attempt to not parallelize he intersection

* remove rayon prelude

* chore(cargo): update dependencies and modernize crate

* chore(cargo): update lock via cargo update

---------

Co-authored-by: Clément Michaud <clement.michaud34@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for SIMD support