Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

release.yml: use correct target_commitish arg #1381

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

mjcheetham
Copy link
Collaborator

Use the correct name for setting the target of a tag in the release workflow, for creating a draft release.

It should be target_commitish not tag_commitish.

https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release

Thanks to @dscho for realising my error.

Use the correct name for setting the target of a tag in the release
workflow, for creating a draft release.
@mjcheetham mjcheetham added bug A bug in Git Credential Manager engineering Refactoring or build changes labels Aug 16, 2023
@mjcheetham mjcheetham enabled auto-merge August 16, 2023 19:11
@mjcheetham mjcheetham merged commit a74fe18 into git-ecosystem:main Aug 16, 2023
mjcheetham added a commit that referenced this pull request Nov 1, 2023
**Changes:**

- Add support for managed identity and service principals in Azure Repos
(#1372)
- Support universal Gitea OAuth app configuration (#1442)
- Set default generic OAuth redirect URI value (#1444)
- Drop WPF helpers on Windows (#1417)
- Add software rendering override for Windows (#1445, #1453)
- Recognise GitLab hosts via WWW-Authenticate header (#1428)
- Recognise Bitbucket hosts via WWW-Authenticate header (#1441)
- Support GitHub Gist remote URLs (#1402)
- Update to Avalonia 11.x (#1383)
- Documentation updates (#1416)
- Drop unnecessary .NET Framework-specific code (#1447)
- Updates to release process (#1386, #1381)
- Update code signing certificates (#1431)
mjcheetham added a commit that referenced this pull request Nov 1, 2023
**Changes:**

_Since 2.4.0:_

- Fix macOS ARM64 tarball contents (#1458)

_Since 2.3.x:_

- Add support for managed identity and service principals in Azure Repos
(#1372)
- Support universal Gitea OAuth app configuration (#1442)
- Set default generic OAuth redirect URI value (#1444)
- Drop WPF helpers on Windows (#1417)
- Add software rendering override for Windows (#1445, #1453)
- Recognise GitLab hosts via WWW-Authenticate header (#1428)
- Recognise Bitbucket hosts via WWW-Authenticate header (#1441)
- Support GitHub Gist remote URLs (#1402)
- Update to Avalonia 11.x (#1383)
- Documentation updates (#1416)
- Drop unnecessary .NET Framework-specific code (#1447)
- Updates to release process (#1386, #1381)
- Update code signing certificates (#1431)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug A bug in Git Credential Manager engineering Refactoring or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants