Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

default OAuth redirect URI to http://127.0.0.1 #1444

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

hickford
Copy link
Contributor

No description provided.

Copy link
Collaborator

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to set a sensible default! Just remember to also update the documentation around this, clarifying that it's now optional to set redirect URI (and that the default is 127.0.0.1).

Docs are in docs/generic-oauth.md

@mjcheetham mjcheetham added the auth:oauth Specific to OAuth2 authentication label Oct 23, 2023
@mjcheetham mjcheetham self-assigned this Oct 23, 2023
@hickford hickford marked this pull request as ready for review October 23, 2023 20:51
@hickford hickford requested a review from mjcheetham October 23, 2023 20:51
@mjcheetham mjcheetham merged commit e549586 into git-ecosystem:main Oct 24, 2023
mjcheetham added a commit that referenced this pull request Nov 1, 2023
**Changes:**

- Add support for managed identity and service principals in Azure Repos
(#1372)
- Support universal Gitea OAuth app configuration (#1442)
- Set default generic OAuth redirect URI value (#1444)
- Drop WPF helpers on Windows (#1417)
- Add software rendering override for Windows (#1445, #1453)
- Recognise GitLab hosts via WWW-Authenticate header (#1428)
- Recognise Bitbucket hosts via WWW-Authenticate header (#1441)
- Support GitHub Gist remote URLs (#1402)
- Update to Avalonia 11.x (#1383)
- Documentation updates (#1416)
- Drop unnecessary .NET Framework-specific code (#1447)
- Updates to release process (#1386, #1381)
- Update code signing certificates (#1431)
mjcheetham added a commit that referenced this pull request Nov 1, 2023
**Changes:**

_Since 2.4.0:_

- Fix macOS ARM64 tarball contents (#1458)

_Since 2.3.x:_

- Add support for managed identity and service principals in Azure Repos
(#1372)
- Support universal Gitea OAuth app configuration (#1442)
- Set default generic OAuth redirect URI value (#1444)
- Drop WPF helpers on Windows (#1417)
- Add software rendering override for Windows (#1445, #1453)
- Recognise GitLab hosts via WWW-Authenticate header (#1428)
- Recognise Bitbucket hosts via WWW-Authenticate header (#1441)
- Support GitHub Gist remote URLs (#1402)
- Update to Avalonia 11.x (#1383)
- Documentation updates (#1416)
- Drop unnecessary .NET Framework-specific code (#1447)
- Updates to release process (#1386, #1381)
- Update code signing certificates (#1431)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
auth:oauth Specific to OAuth2 authentication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants