Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Setting dataLabelPosition to a line chart causes latest office application to ask for repair #768

Closed
1 of 4 tasks
artdomg opened this issue Jun 12, 2020 · 3 comments
Closed
1 of 4 tasks
Milestone

Comments

@artdomg
Copy link

artdomg commented Jun 12, 2020

Category

  • Enhancement
  • Bug
  • Question
  • Documentation gap/issue

Version

Please specify what version of the library you are using: [3.2.1 ]

Please specify what version(s) of PowerPoint you are targeting: [16.37 (2020)]

Expected / Desired Behavior / Question

PPTX files should be able to open on Microsoft PowerPoint

Observed Behavior

When adding a line chart with dataLabelPosition set, Microsoft Office application asks to repair the file and fails to do it.

Code sample

slide.addChart( ppt.ChartType.line, [ { name: 'Foo', labels: ['bar'], values: [1] } ], { dataLabelPosition: 'bestFit' } );

@gitbrent
Copy link
Owner

There are lots of demo charts that utilize the dataLabelPosition option, so it's likely that 'bestFit' doesn't work well with Line Charts.

@ReimaFrgos
Copy link
Contributor

bestFit isn't a valid label position for line charts:

image

It's used for Pie and Doughnut charts

@gitbrent
Copy link
Owner

Fixed via Pull #938

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants