Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Chart Validation #789

Closed
wants to merge 1 commit into from
Closed

Chart Validation #789

wants to merge 1 commit into from

Conversation

ReimaFrgos
Copy link
Contributor

@gitbrent The attached edits should help eliminate repair errors resulting from improperly configured charts. Configurable values are checked against valid options by chart type.

Should resolve errors referenced in:
#788 #768

Should resolve previously worked around issues for Office Online.

Updates run successfully against all Chart demo's. The only slide change is the Bubble Chart demo on Slide 15, bottom left. The data labels shift from center to right as per default MS Office behaviour. This could be addresses by either tweaking the edit to default this to Center, or update the demo too set the position to center.

@gitbrent
Copy link
Owner

gitbrent commented Jul 4, 2020

Thanks @ReimaFrgos - would you mind patching the ./src file instead :)

@ReimaFrgos
Copy link
Contributor Author

@gitbrent closing this PR and replacing with #790 instead which updates the ./src files instead.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants