Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Multiple Chart Enhancements and Bugfixes #938

Merged
merged 1 commit into from
May 17, 2021

Conversation

ReimaFrgos
Copy link
Contributor

This update addresses a number of the outstanding bugs and requests for working with Charts.

Issue #858 :

  1. Added a new configuration option: serAxisLineColor
  2. Added support to use schemeColor on Category Axis Label (catAxisLabelColor)
  3. Added support to use schemeColor on Category Axis Line (catAxisLineColor)
  4. Added support to use schemeColor on Value Axis Label (valAxisLabelColor)
  5. Added support to use schemeColor on Value Axis Line (valAxisLineColor)
  6. Added support to use schemeColor on Series Axis Label (serAxisLabelColor)
  7. Added support to use schemeColor on Series Axis Line (serAxisLineColor)
  8. Added support to use schemeColor on Chart Title (titleColor)
  9. Added support to use schemeColor on Category Axis Title (catAxisTitleColor)
  10. Added support to use schemeColor on Value Axis Title (valAxisTitleColor)
  11. Added support to use schemeColor on Series Axis Title (serAxisTitleColor)

Issue #837 : This has already been patched. Patch is still in this release and issue should be able to be closed.

Issue #747 : Added support for catAxisMajorUnit and catAxisMinor unit to function correctly with double value axis chart types (Scatter Chart + Bubble Chart)

Issue #662 : Fixed issue for dataLabelFontBold to correctly bold data labels.

Issue #815 : This was an invalid input that should no longer be allowed after this PR

Issue #788 : This was an invalid input that should no longer be allowed after this PR

Issue #768 : This was an invalid input that should no longer be allowed after this PR

Additional Enhancements:

  1. Added serAxisLabelFontBold to the code so that it functions as per the documentation.
  2. Added Italic support for chart labels:
    2.1. New configuration: catAxisLabelFontItalic
    2.2. New configuration: serAxisLabelFontItalic
    2.3. New configuration: valAxisLabelFontItalic
    2.4. New configuration: dataLabelFontItalic

Additional Issues Reviewed, but not specifically in this release:
Issue #441 : This feature has already been implemented and should be safe to close.

Issue #291 : This feature has already been implemented and should be safe to close.

This PR replaces PR #794 which can be cancelled / closed

Everything has tested successfully against the full demo build.

@gitbrent gitbrent self-assigned this May 9, 2021
@gitbrent gitbrent added this to the 3.7.0 milestone May 9, 2021
gitbrent added a commit that referenced this pull request May 17, 2021
gitbrent added a commit that referenced this pull request May 17, 2021
@gitbrent gitbrent merged commit 2b7834c into gitbrent:master May 17, 2021
@gitbrent
Copy link
Owner

Thank you very much @ReimaFrgos ! The backlog was becoming daunting.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants