Enhanced view of uncommitted changes in Browse Repository #4031
Comments
|
The working dir changes can be seen from the Browse window, but there is no ability to perform commit related actions. See https://git-extensions-documentation.readthedocs.io/en/latest/settings.html#git-extensions-performance-working-dir-changes |
|
Great - how did I miss that setting? (Should be on by default - what is slowing down?). This feature request is then about how this should work - mostly all already marked with "Enhancement". I can rephrase the description. |
I don't know, never have experience a slow down. You should ask the author.
Please do that, as it is already very long. Could you also attach sketched pictures of existing windows showing us new buttons, context menus and other changes you would like to do. Perhaps we will create new subissues to discus each proposed change in separation (I predict long discussions here, see #564 it may be helpful). |
gerhardol
changed the title
|
Rephrased the description, moved some parts to other issues. For instance editing unstaged commit message could be "implemented in the context of this issue" but at least pull requests should be separate. But most of the basic functionality I wanted is already implemented! |
|
I don't know, never have experience a slow down. You should ask the
author.
This setting was added 7 years ago by Henk
3d84909
…On 2 October 2017 at 07:27, Janusz Białobrzewski ***@***.***> wrote:
what is slowing down?
I don't know, never have experience a slow down. You should ask the author.
I can rephrase the description.
Please do that, as it is already very long. Could you also attach sketched
pictures of existing windows showing us new buttons, context menus and
other changes you would like to do. Perhaps we will create new subissues to
discus each proposed change in separation (I predict long discussions here,
see #564 <#564> it
may be helpful).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4031 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEMyXjnLfL6QzkLnYf_2j2QiWB3VguXsks5sn_WUgaJpZM4Pp_to>
.
|
|
Commit comment by @spdr870:
Anything different from GetAllChangedFiles() (that I assume is what slowing down) compared to what is done for the Commit count button? @RussKie Thanks for finding this. I am lost in the code (of course, randomly looking at a problem will get one lost). I believe #4033 should result in default being changed for new installations, similar to other clients (but GitExt can do this better). |
|
I have implemented a rough version of the "Diff" changes. There is currently a lot of special checks for artificial commits, a lot of that handling can be replaced with special diff options. However, some special handling should be added for the menu items (all current options are not relevant like "diff to local"). I updated the description some. I currently plan to clean up the handling and submit three merge requests:
|
|
https://github.com/gerhardol/gitextensions/tree/feature/n4031-artificial-commit-diff A branch with changes I would like to do to improve this handling The handling for artificial commits was simplified for diff, but code was added to handle artificial commits properly in other situations (there were a lot functions that does not work well with artificial commits already). I also added some new functionality, some inspired from Commit menu options. I will submit some separate patches to start with. As the changes have evolved together over time and I have rebased and squashed continuously, the changes has not been tested in this order. |
|
First set of PRs submitted. Awaiting primarily #4079 before continuing, will probably close and reopen #4081 due to #4079 The most important commit is gerhardol@7234d28 |
…use FileSystemWatcher) is activated This change originates in gitextensions#4031 but can also be used as a workaround for limitations due to gitextensions#4069
|
Do you think that this empty place (for artificial revisions) could be used for commit message and commit button?
|
As gitextensions#4031 is more or less merged
… count at changes Part of gitextensions#4031 * Move out UI specific from ToolStripGitStatus to GitStatusMonitor * Restructured and moved the code in GitStatusMonitor to respective groups (public, private, handlers etc) * Added events to notify consumers. The update of GUI components is moved from GitStatusMonitor to FormBrowse, also updating artificial commit count
|
@gerhardol do you think we can close the current issue for the work which went into 2.51, and start a new issue for the remaining work which will go into the next version? |
|
#4209 is connected to this issue, can be connected to a new. |
|
Awesome job, mate. |
New functionality in 2.50.02 gitextensions#4031, regression from gitextensions#4208 9f5fe41
* Move ToolStripGitStatus to GitStatusMonitor, update artificial commit count at changes Part of #4031 * Move out UI specific from ToolStripGitStatus to GitStatusMonitor * Restructured and moved the code in GitStatusMonitor to respective groups (public, private, handlers etc) * Added events to notify consumers. The update of GUI components is moved from GitStatusMonitor to FormBrowse, also updating artificial commit count
New functionality in 2.50.02 gitextensions#4031, regression from gitextensions#4208 9f5fe41
Issue gitextensions#4031 had several issues that improved the functionality and limited unusable menus, but some checks were not entirely correct or could be simplified to just limit on IsTracked Some diff-to-parent were not always shown FileHistory and Blame should be disabled for Untracked Browse Diff disabled for all artificial but formDiff did not not disable for any Browse Diff Cherry-pick completely disabled for artificial
…have a consistent naming This was discussed in gitextensions#4313, the core files in the PR was changed already firstRevision/secondRevision was the most commonly used arguments. Some arguments have been aligned to from/to in gitextensions#4031 PRs. Other names discussedwas revA/revB.
…have a consistent naming This was discussed in gitextensions#4313, the core files in the PR was changed already firstRevision/secondRevision was the most commonly used arguments. Some arguments have been aligned to from/to in gitextensions#4031 PRs. Other names discussed was revA/revB.
#4344) * Rename arguments related to diff to firstRevision, secondRevision to have a consistent naming This was discussed in #4313, the core files in the PR was changed already firstRevision/secondRevision was the most commonly used arguments. Some arguments had previously been aligned to from/to in #4031 PRs. Other names discussed was revA/revB.
Issue gitextensions#4396 Issue gitextensions#4031 had several PRs that improved the functionality and limited unusable menus, but some checks were not entirely correct or could be simplified to just IsTracked Some diff-to-parent were not always shown FileHistory and Blame must be disabled for Untracked files Browse Diff disabled for all artificial but formDiff did not not disable for any Browse Diff Cherry-pick completely disabled for artificial
As gitextensions#4031 is more or less merged
As gitextensions#4031 is more or less merged
As gitextensions#4031 is more or less merged
Do you want to request a feature or report a bug?
Feature
What is the current behavior?
It is possible to see staged/working directory changes in the Browse Repository, but the behavior can be improved:
Future
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
What is the expected behavior?
I have moved some related suggestions to #564. A few of them could be seen as improvements in this feature too.
Considered but dropped suggestions:
Improve information for "Commit index" and "Current unstaged changes" in the tree view:
-> While this could be interesting, it will only be a subset of the Diff tab anyway.
See Commit tab, for complete commit message (and parent hash)
-> Just minor of the info is relevant, quite simple to just select the current HEAD anyway.
File tree tab is currently hidden for unstaged. Should show similar info as for a commit (staged the index tree, unstaged just file explorer?.
-> There seem to be no obvious way to get the file tree for staged, 'ls-tree' has no --cached option. For unstaged a file explorer could be implemented though.
Note: Both Commit, FileTree tabs reenbled for artificial commits in fix: Do not hide tabs for artificial commits #4275
Environment you encounter the issue:
Did this work in previous version of GitExtensions (which)?
Same in all GitExt
The text was updated successfully, but these errors were encountered: