Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Debug builds fails at commit if reallocated #4075

Merged

Conversation

gerhardol
Copy link
Member

Fix as seen in #4031

Changes proposed in this pull request:

  • Possibility to move the installation files for Debug builds to paths shorter than build path

Screenshots before and after (if PR changes UI):
-No

How did I test this code:

  • Copied bin/Debug to upper directories

Has been tested on (remove any that don't apply):

  • GIT 2.14 (not Git dependent)
  • Windows 7 and Win10

@RussKie
Copy link
Member

RussKie commented Oct 22, 2017

Could you please clarify the use case for this?

@gerhardol
Copy link
Member Author

I have built the debug package at home and want to test it at work

The change only affects debug build and is obviously incorrect...

@RussKie
Copy link
Member

RussKie commented Oct 22, 2017 via email

@gerhardol
Copy link
Member Author

It sure works if you copy it to a deep enough path, if the new path length is larger than the path it was compiled in

Current code
int len = debugPath.Length;
var path = gitExtDir.Substring(gitExtDir.Length - len);

New
int len = debugPath.Length;
if (gitExtDir.Length > len)

@RussKie RussKie merged commit b1f7bbe into gitextensions:master Oct 23, 2017
@RussKie RussKie added this to the 2.51 milestone Oct 23, 2017
@gerhardol gerhardol deleted the bugfix/n4031-debug-allocate-fails branch November 11, 2017 11:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants