-
-
Notifications
You must be signed in to change notification settings - Fork 934
gitpython-2.0.9.dev0 has run-time dependency on nose #526
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Yeap, thanks for this one. It is due code disabling failing Windows TCs, enacted on #525. |
+ Move `HIDE_WINDOWS_KNOWN_ERRORS` flag from `git.test.lib.helper-->git.util`; regular modules in main-sources folder also depend on that flag. + Use unittest.SkipTest instead of from non-standard `nose` lib.
@Byron I need to revert master in order to merge. Can I? |
@ankostis Please feel free to do whatever you think has to be done. You have my full trust. Sorry for the hassle, when I merged it was green on AppVeyor, at least according to github :/. |
Can we get a new release go go along with this fix? |
For that we are expecting the dependency projects snmap and gitdb, to release also in PyPi: gitpython-developers/smmap#28 |
I'm afraid I don't follow. Can you explain how that's related and when a release might happen? |
@ClaytonONeill I have just pushed dev1, which should contain the fix required to allow installations to work. I have also un-hidden the last non-dev version, which should hopefully allow installers to gravitate towards the stable version. |
I have also hidden the previous dev release entirely, which ideally fixes the issue for good. |
Installing recently-released GitPython==2.0.9.dev0 results in 'No module named nose.tools' error on 'import git':
I realise that 2.0.9.dev0 is not installed by pip by default, due to being a dev version, but I'm getting gitpython as a transitive dependency via git-upstream, which has a pre-release constraint on gitpython:
The text was updated successfully, but these errors were encountered: