Stop emulating mmap on Windows #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obviously it is not needed anymore, or nothing is worse without this monkeypatch.
Now 2 more TCs pass in Windows: + TestRepo.test_file_handle_leaks() + TestObjDbPerformance.test_random_access() See gitpython-developers/smmap#30
Current coverage is 94.38% (diff: 100%)@@ master #542 diff @@
==========================================
Files 63 63
Lines 9885 9875 -10
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 9326 9321 -5
+ Misses 559 554 -5
Partials 0 0
|
|
@ankostis Should I merge this one as well ? Maybe it's tied to the ongoing PR in smmap and should thus wait. |
|
Yes, it is tied as you said. |
|
Thank you ! It's in - if you think I should push it right away as 2.1.1, please let me know. Otherwise it will just be part of the next natural point release in a few weeks. |
|
No, no prob. Thanks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the matching-fix of gitpython-developers/smmap#30
Now 2 more "hidden-errors" TCs pass in Windows (see #525):