-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refactor flow's config to use a minimal amount of signac's config module #649
Conversation
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
==========================================
+ Coverage 79.81% 79.85% +0.04%
==========================================
Files 33 33
Lines 3195 3187 -8
Branches 681 681
==========================================
- Hits 2550 2545 -5
+ Misses 507 505 -2
+ Partials 138 137 -1
Continue to review full report at Codecov.
|
Removes dependence on signac.common.config.
This allows the sharing of some useful base classes to multiple test files.
Creates a test file for template filters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config changes look great. I have a few comments on the changes in conftest.py
(which seem unnecessary to me) but I'm approving the core of the config-related changes.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
for more information, see https://pre-commit.ci
@b-butler Please update the changelog and then this can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. Thanks!
Description
flow.util.config.get_config_value
. Removes an extant template filter.flow.util.config.require_config_value
take a project.flow.util.config.require_config_value
toflow.util.config.get_config_value
. This could potential trip users up if they use our template filter as now the behavior changes.flow.environment.ComputeEnvironment.get_config_value
. Use the project to get environment specific configuration values.signac.common.config.read_config_file
andload_config
everywhere.We no longer depend at all on
signac.common.config
.Motivation and Context
signac
is significantly reducing its Python config API, and this prepares for that change.Checklist: