-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove import packaged environments #653
Conversation
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
==========================================
- Coverage 79.14% 79.07% -0.07%
==========================================
Files 33 33
Lines 3241 3231 -10
Branches 687 685 -2
==========================================
- Hits 2565 2555 -10
- Misses 535 536 +1
+ Partials 141 140 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I didn't even know that this existed
* depr: Warn on use of environment_modules * depr: Warn on use of import_packaged_environments * refactor!: Remove import_packaged_environments from configuration * doc: Update changelog
* depr: Warn on use of environment_modules * depr: Warn on use of import_packaged_environments * refactor!: Remove environment_modules * style: Rename internal variable * Remove import packaged environments (#653) * depr: Warn on use of environment_modules * depr: Warn on use of import_packaged_environments * refactor!: Remove import_packaged_environments from configuration * doc: Update changelog * doc: Update changelog
Note; To merge after #651
Description
Removes
import_packaged_environments
from the configuration.Motivation and Context
This is a move to make #649 simpler and our dependence on
signac
's config to be purely at the project level in Python.Checklist: