fix: Allow for .next to be a MouseInteraction and clean up its event handlers #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to debug which event handlers are attached to the DOM.
…handlers We now remove the .drag event handlers, but, because multiple MouseInteractions share the same DOM node and event name, this will remove all event handlers. Therefore, if the 'parent' MouseInteraction reattaches its event handlers when .next changes this is not an issue. Also, if .next changes quickly, we might attach a stale interaction because we awaited while in the meantime .next already changed. This caused event handlers to be added, and never removed.
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 55.38% 55.38%
=======================================
Files 7 7
Lines 130 130
=======================================
Hits 72 72
Misses 58 58 Continue to review full report at Codecov.
|
|
Note that this does not seem to be a problem in Jupyter lab, which I am not sure if it can be considered a notebook issue, but I commented on this at March 2, 2022 1:18 PM |
|
@kecnry This should fix the issues you mentioned in spacetelescope/jdaviz#1013 (comment) but it would be great if you can confirm it. |
|
Seems to have done the trick! Thanks @maartenbreddels! |
kecnry
added a commit
to kecnry/jdaviz
that referenced
this pull request
Mar 8, 2022
* glue-viz/bqplot-image-gl#86 which fixes a bug in the slice indicator sliding noted in spacetelescope#1013 (comment)
9 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Allow for .next to be a MouseInteraction and clean up its event handlers
We now remove the .drag event handlers, but, because multiple MouseInteractions
share the same DOM node and event name, this will remove all event handlers.
Therefore, if the 'parent' MouseInteraction reattaches its event handlers
when .next changes this is not an issue.
Also, if .next changes quickly, we might attach a stale interaction
because we awaited while in the meantime .next already changed.
This caused event handlers to be added, and never removed.