Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bump bqplot version to fix slice indicator drag event #1149

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Mar 8, 2022

Description

This pull request fixes the issue in #1013 (comment) by bumping the bqplot version to include glue-viz/bqplot-image-gl#86.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

* glue-viz/bqplot-image-gl#86 which fixes a bug in the slice indicator sliding noted in spacetelescope#1013 (comment)
@kecnry kecnry added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Mar 8, 2022
@kecnry kecnry added this to the 2.4 milestone Mar 8, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #1149 (66d1332) into main (a35f93a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1149   +/-   ##
=======================================
  Coverage   76.66%   76.66%           
=======================================
  Files          82       82           
  Lines        6483     6483           
=======================================
  Hits         4970     4970           
  Misses       1513     1513           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a35f93a...66d1332. Read the comment docs.

@pllim pllim merged commit 49b731e into spacetelescope:main Mar 8, 2022
@kecnry kecnry deleted the fix-drag-event branch March 8, 2022 15:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants