Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix flag validation #19046

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Fix flag validation #19046

merged 2 commits into from
Mar 10, 2022

Conversation

noerw
Copy link
Member

@noerw noerw commented Mar 9, 2022 •
edited by zeripath
Loading

Regression from #5785

@noerw noerw added the type/bug label Mar 9, 2022
@noerw noerw added this to the 1.17.0 milestone Mar 9, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 9, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 10, 2022
@zeripath zeripath merged commit 5fdd304 into go-gitea:main Mar 10, 2022
@zeripath
Copy link
Contributor

Please send backport.

noerw added a commit to noerw/gitea that referenced this pull request Mar 10, 2022
@noerw
Fix flag validation (go-gitea#19046)
f148df3 
Regression from go-gitea#5785
@noerw noerw mentioned this pull request Mar 10, 2022
Merged
@noerw noerw added the backport/done All backports for this PR have been created label Mar 10, 2022
zeripath pushed a commit that referenced this pull request Mar 10, 2022
@noerw
Fix flag validation (#19046) (#19051)
580401e 
Regression from #5785
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 11, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
151563f 
* giteaofficial/main:
  Prevent 500 when there is an error during new auth source post (go-gitea#19041)
  Update the webauthn_credential_id_sequence in Postgres (go-gitea#19048)
  If rendering has failed due to a net.OpError stop rendering (attempt 2) (go-gitea#19049)
  use xorm builder for models.getReviewers() (go-gitea#19033)
  RSS/Atom support for Orgs (go-gitea#17714)
  Fix flag validation (go-gitea#19046)
  Improve SyncMirrors logging (go-gitea#19045)
@6543 6543 deleted the fix-cli branch March 14, 2022 21:43
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@noerw
Fix flag validation (go-gitea#19046)
723ccbd 
Regression from go-gitea#5785
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@zeripath zeripath zeripath approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@noerw @zeripath @wxiaoguang @GiteaBot